Improve GN handling of directory templates.

tools/gn/filesystem_utils_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "tools/gn/filesystem_utils.h"
 
@@ skipping 72 matching lines @@
   SourceDir srcroot("//");
   EXPECT_EQ("", FindLastDirComponent(srcroot));
 
   SourceDir regular1("//foo/");
   EXPECT_EQ("foo", FindLastDirComponent(regular1));
 
   SourceDir regular2("//foo/bar/");
   EXPECT_EQ("bar", FindLastDirComponent(regular2));
 }
 
+TEST(FilesystemUtils, EnsureStringIsInOutputDir) {
+  SourceDir output_dir("//out/Debug/");
+
+  // Some outside.
+  Err err;
+  EXPECT_FALSE(EnsureStringIsInOutputDir(output_dir, "//foo", Value(), false,
+                                         &err));
+  EXPECT_TRUE(err.has_error());
+  err = Err();
+  EXPECT_FALSE(EnsureStringIsInOutputDir(output_dir, "//out/Debugit", Value(),
+                                         false, &err));
+  EXPECT_TRUE(err.has_error());
+
+  // Some inside.
+  err = Err();
+  EXPECT_TRUE(EnsureStringIsInOutputDir(output_dir, "//out/Debug/", Value(),
+                                        false, &err));
+  EXPECT_FALSE(err.has_error());
+  EXPECT_TRUE(EnsureStringIsInOutputDir(output_dir, "//out/Debug/foo", Value(),
+                                        false, &err));
+  EXPECT_FALSE(err.has_error());
+
+  // Pattern but no template expansions are allowed.
+  EXPECT_FALSE(EnsureStringIsInOutputDir(output_dir, "{{source_gen_dir}}",
+                                         Value(), false, &err));
+  EXPECT_TRUE(err.has_error());
+
+  // Pattern with template expansions allowed.
+  err = Err();
+  EXPECT_TRUE(EnsureStringIsInOutputDir(output_dir, "{{source_gen_dir}}",
+                                        Value(), true, &err));
+  EXPECT_FALSE(err.has_error());
+
+  // Template expansion that doesn't include the absolute directory.
+  EXPECT_FALSE(EnsureStringIsInOutputDir(output_dir, "{{source}}",
+                                         Value(), true, &err));
+  EXPECT_TRUE(err.has_error());
+  err = Err();
+  EXPECT_FALSE(EnsureStringIsInOutputDir(output_dir,
+                                        "{{source_root_relative_dir}}",
+                                        Value(), true, &err));
+  EXPECT_TRUE(err.has_error());
+}
+
 TEST(FilesystemUtils, IsPathAbsolute) {
   EXPECT_TRUE(IsPathAbsolute("/foo/bar"));
   EXPECT_TRUE(IsPathAbsolute("/"));
   EXPECT_FALSE(IsPathAbsolute(""));
   EXPECT_FALSE(IsPathAbsolute("//"));
   EXPECT_FALSE(IsPathAbsolute("//foo/bar"));
 
 #if defined(OS_WIN)
   EXPECT_TRUE(IsPathAbsolute("C:/foo"));
   EXPECT_TRUE(IsPathAbsolute("C:/"));
@@ skipping 289 matching lines @@
   build_settings.SetBuildDir(SourceDir("//"));
   Settings settings(&build_settings, "");
 
   EXPECT_EQ("//", GetToolchainOutputDir(&settings).value());
   EXPECT_EQ("//gen/", GetToolchainGenDir(&settings).value());
   EXPECT_EQ("//obj/",
             GetOutputDirForSourceDir(&settings, SourceDir("//")).value());
   EXPECT_EQ("//gen/",
             GetGenDirForSourceDir(&settings, SourceDir("//")).value());
 }