Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 387413003: Drop findAttribute*ByName() API from Element (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Drop findAttribute*ByName() API from Element Drop findAttribute*ByName() API from Element and use the AttributeCollection API instead. This makes it more likely for callers to reuse to AttributeCollection and thus avoid unnecessary and implicit ElementData::isUnique() checks. This also avoid API duplication between Element and AttributeCollection. R=esprehn@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -23 lines) Patch
M Source/core/dom/Element.h View 3 chunks +4 lines, -13 lines 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 5 months ago (2014-07-14 18:38:53 UTC) #1
adamk
lgtm
6 years, 5 months ago (2014-07-14 18:41:52 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 5 months ago (2014-07-14 18:43:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/387413003/1
6 years, 5 months ago (2014-07-14 18:45:26 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-14 19:36:54 UTC) #5
Message was sent while issue was closed.
Change committed as 178095

Powered by Google App Engine
This is Rietveld 408576698