Issue 387413003: Drop findAttribute*ByName() API from Element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387413003: Drop findAttribute*ByName() API from Element (Closed)

Created:
6 years, 5 months ago by Inactive

Modified:
6 years, 5 months ago

Reviewers:
esprehn, adamk

CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Drop findAttribute*ByName() API from Element Drop findAttribute*ByName() API from Element and use the AttributeCollection API instead. This makes it more likely for callers to reuse to AttributeCollection and thus avoid unnecessary and implicit ElementData::isUnique() checks. This also avoid API duplication between Element and AttributeCollection. R=esprehn@chromium.org, adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178095

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -23 lines)			Patch
M	Source/core/dom/Element.h	View	3 chunks	+4 lines, -13 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/NamedNodeMap.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLInputElement.cpp	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	Source/core/html/parser/HTMLConstructionSite.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/xml/XPathFunctions.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/387413003/1

6 years, 5 months ago (2014-07-14 18:45:26 UTC) #4

Message was sent while issue was closed.

Change committed as 178095

Expand Messages | Collapse Messages