Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 387413003: Drop findAttribute*ByName() API from Element (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/NamedNodeMap.cpp ('k') | Source/core/html/parser/HTMLConstructionSite.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 AtomicString valueString = fastGetAttribute(valueAttr); 446 AtomicString valueString = fastGetAttribute(valueAttr);
447 m_valueIfDirty = sanitizeValue(valueString); 447 m_valueIfDirty = sanitizeValue(valueString);
448 } else 448 } else
449 updateValueIfNeeded(); 449 updateValueIfNeeded();
450 450
451 m_needsToUpdateViewValue = true; 451 m_needsToUpdateViewValue = true;
452 m_inputTypeView->updateView(); 452 m_inputTypeView->updateView();
453 453
454 if (didRespectHeightAndWidth != m_inputType->shouldRespectHeightAndWidthAttr ibutes()) { 454 if (didRespectHeightAndWidth != m_inputType->shouldRespectHeightAndWidthAttr ibutes()) {
455 ASSERT(elementData()); 455 ASSERT(elementData());
456 if (const Attribute* height = findAttributeByName(heightAttr)) 456 AttributeCollection attributes = this->attributes();
457 if (const Attribute* height = attributes.find(heightAttr))
457 attributeChanged(heightAttr, height->value()); 458 attributeChanged(heightAttr, height->value());
458 if (const Attribute* width = findAttributeByName(widthAttr)) 459 if (const Attribute* width = attributes.find(widthAttr))
459 attributeChanged(widthAttr, width->value()); 460 attributeChanged(widthAttr, width->value());
460 if (const Attribute* align = findAttributeByName(alignAttr)) 461 if (const Attribute* align = attributes.find(alignAttr))
461 attributeChanged(alignAttr, align->value()); 462 attributeChanged(alignAttr, align->value());
462 } 463 }
463 464
464 if (document().focusedElement() == this) 465 if (document().focusedElement() == this)
465 document().updateFocusAppearanceSoon(true /* restore selection */); 466 document().updateFocusAppearanceSoon(true /* restore selection */);
466 467
467 setChangedSinceLastFormControlChangeEvent(false); 468 setChangedSinceLastFormControlChangeEvent(false);
468 469
469 addToRadioButtonGroup(); 470 addToRadioButtonGroup();
470 471
(...skipping 1408 matching lines...) Expand 10 before | Expand all | Expand 10 after
1879 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer()); 1880 return m_inputTypeView->customStyleForRenderer(originalStyleForRenderer());
1880 } 1881 }
1881 #endif 1882 #endif
1882 1883
1883 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue) 1884 bool HTMLInputElement::shouldDispatchFormControlChangeEvent(String& oldValue, St ring& newValue)
1884 { 1885 {
1885 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ; 1886 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ;
1886 } 1887 }
1887 1888
1888 } // namespace 1889 } // namespace
OLDNEW
« no previous file with comments | « Source/core/dom/NamedNodeMap.cpp ('k') | Source/core/html/parser/HTMLConstructionSite.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698