Source/core/dom/Element.cpp - Issue 387413003: Drop findAttribute*ByName() API from Element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 387413003: Drop findAttribute*ByName() API from Element (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 41a571aff9a0c9bec59490b80bc32245ec66f04d..d7b4a1239835cec7ba4f6b992c0368b535cda941 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -431,7 +431,7 @@ const AtomicString& Element::getAttribute(const QualifiedName& name) const

if (!elementData())

return nullAtom;

synchronizeAttribute(name);

- if (const Attribute* attribute = findAttributeByName(name))

+ if (const Attribute* attribute = attributes().find(name))

return attribute->value();

return nullAtom;

}

@@ -2631,7 +2631,7 @@ KURL Element::getURLAttribute(const QualifiedName& name) const

{

#if ASSERT_ENABLED

if (elementData()) {

- if (const Attribute* attribute = findAttributeByName(name))

+ if (const Attribute* attribute = attributes().find(name))

ASSERT(isURLAttribute(*attribute));

}

#endif

@@ -2642,7 +2642,7 @@ KURL Element::getNonEmptyURLAttribute(const QualifiedName& name) const

{

#if ASSERT_ENABLED

if (elementData()) {

- if (const Attribute* attribute = findAttributeByName(name))

+ if (const Attribute* attribute = attributes().find(name))

ASSERT(isURLAttribute(*attribute));

}

#endif

« no previous file with comments | « Source/core/dom/Element.h ('k') | Source/core/dom/NamedNodeMap.cpp » ('j') | no next file with comments »