Issue 387353002: Extra parameter to pass sub-message direction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387353002: Extra parameter to pass sub-message direction (Closed)

Created:
6 years, 5 months ago by Habib Virji

Modified:
6 years, 5 months ago

Reviewers:
darin (slow to review), benm (inactive)

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Extra parameter to pass sub-message direction Main message and sub message direction can differ. Pass direction of the subMsg to allow display accordingly. BUG=91638 R=benm, darin

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -11 lines)			Patch
	M	content/renderer/render_view_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/renderer/render_view_impl.cc	View		1 chunk	+12 lines, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Habib Virji

6 years, 5 months ago (2014-07-14 14:55:27 UTC) #1

Corresponding blink changes: https://codereview.chromium.org/389343002/. 

Was not sure about tests relevant for this. Please suggest if test are
applicable for this change.

Expand Messages | Collapse Messages