Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: content/renderer/render_view_impl.cc

Issue 387353002: Extra parameter to pass sub-message direction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 154c0cb394b79dffdb49ebec54066ddb1cfd9ce1..4066be431253a6d8f15afc6654814a1bd7e4c22f 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -1600,23 +1600,24 @@ bool RenderViewImpl::runFileChooser(
void RenderViewImpl::showValidationMessage(
const blink::WebRect& anchor_in_root_view,
const blink::WebString& main_text,
+ blink::WebTextDirection main_text_hint,
const blink::WebString& sub_text,
- blink::WebTextDirection hint) {
+ blink::WebTextDirection sub_text_hint) {
base::string16 wrapped_main_text = main_text;
base::string16 wrapped_sub_text = sub_text;
- if (hint == blink::WebTextDirectionLeftToRight) {
+ if (main_text_hint == blink::WebTextDirectionLeftToRight)
wrapped_main_text =
- base::i18n::GetDisplayStringInLTRDirectionality(wrapped_main_text);
- if (!wrapped_sub_text.empty()) {
+ base::i18n::GetDisplayStringInLTRDirectionality(wrapped_main_text);
+ else if (main_text_hint == blink::WebTextDirectionRightToLeft
+ && !base::i18n::IsRTL())
+ base::i18n::WrapStringWithRTLFormatting(&wrapped_main_text);
+
+ if (!wrapped_sub_text.empty()) {
+ if (sub_text_hint == blink::WebTextDirectionLeftToRight)
wrapped_sub_text =
- base::i18n::GetDisplayStringInLTRDirectionality(wrapped_sub_text);
- }
- } else if (hint == blink::WebTextDirectionRightToLeft
- && !base::i18n::IsRTL()) {
- base::i18n::WrapStringWithRTLFormatting(&wrapped_main_text);
- if (!wrapped_sub_text.empty()) {
+ base::i18n::GetDisplayStringInLTRDirectionality(wrapped_sub_text);
+ else if (sub_text_hint == blink::WebTextDirectionRightToLeft)
base::i18n::WrapStringWithRTLFormatting(&wrapped_sub_text);
- }
}
Send(new ViewHostMsg_ShowValidationMessage(
routing_id(), anchor_in_root_view, wrapped_main_text, wrapped_sub_text));
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698