fix for dartbug.com/18692

fix for dartbug.com/18692

R=danrubel@google.com

Committed: https://code.google.com/p/dart/source/detail?r=38233

[danrubel, 2014-07-14 16:22:17]

lgtm

https://codereview.chromium.org/387283002/diff/20001/editor/tools/plugins/com...
File
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java
(right):

https://codereview.chromium.org/387283002/diff/20001/editor/tools/plugins/com...
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java:507:
stream.write("Isolate paused on start. Use the Observatory to release it.\n");
How about "Isolate paused on start waiting for Observatory connection. Select
<menu item to select or button to click> to open Observatory and continue
isolate execution." ? Does that correctly capture the current state and what the
user needs to do to move forward?

[keertip, 2014-07-15 07:49:49]

https://codereview.chromium.org/387283002/diff/20001/editor/tools/plugins/com...
File
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java
(right):

https://codereview.chromium.org/387283002/diff/20001/editor/tools/plugins/com...
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java:507:
stream.write("Isolate paused on start. Use the Observatory to release it.\n");
How about "Isolate paused on start. Click on the  \"Open Observatory\" button in
the Toolbar to open Observatory and continue isolate execution." since the wait
is not for Observatoty connection.

On 2014/07/14 16:22:17, danrubel wrote:
> How about "Isolate paused on start waiting for Observatory connection. Select
> <menu item to select or button to click> to open Observatory and continue
> isolate execution." ? Does that correctly capture the current state and what
the
> user needs to do to move forward?

[danrubel, 2014-07-15 12:54:57]

lgtm

https://codereview.chromium.org/387283002/diff/20001/editor/tools/plugins/com...
File
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java
(right):

https://codereview.chromium.org/387283002/diff/20001/editor/tools/plugins/com...
editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java:507:
stream.write("Isolate paused on start. Use the Observatory to release it.\n");
On 2014/07/15 07:49:49, keertip wrote:
> How about "Isolate paused on start. Click on the  \"Open Observatory\" button
in
> the Toolbar to open Observatory and continue isolate execution." since the
wait
> is not for Observatoty connection.
> 
> On 2014/07/14 16:22:17, danrubel wrote:
> > How about "Isolate paused on start waiting for Observatory connection.
Select
> > <menu item to select or button to click> to open Observatory and continue
> > isolate execution." ? Does that correctly capture the current state and what
> the
> > user needs to do to move forward?
> 

Sgtm!

[keertip, 2014-07-15 14:18:51]

Committed patchset #3 manually as r38233 (presubmit successful).