fix for dartbug.com/18692

editor/tools/plugins/com.google.dart.tools.deploy/src/com/google/dart/tools/ui/console/DartConsoleView.java

 /*
  * Copyright (c) 2012, the Dart project authors.
  *
  * Licensed under the Eclipse Public License v1.0 (the "License"); you may not use this file except
  * in compliance with the License. You may obtain a copy of the License at
  *
  * http://www.eclipse.org/legal/epl-v10.html
  *
  * Unless required by applicable law or agreed to in writing, software distributed under the License
  * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
  * or implied. See the License for the specific language governing permissions and limitations under
  * the License.
  */
 
 package com.google.dart.tools.ui.console;
 
+import com.google.dart.tools.debug.core.DartDebugCorePlugin;
+import com.google.dart.tools.debug.core.DartLaunchConfigWrapper;
 import com.google.dart.tools.debug.ui.launch.OpenObservatoryAction;
 import com.google.dart.tools.debug.ui.launch.StopPubServeAction;
 import com.google.dart.tools.deploy.Activator;
 import com.google.dart.tools.ui.DartToolsPlugin;
 import com.google.dart.tools.ui.actions.InstrumentedAction;
 import com.google.dart.tools.ui.instrumentation.UIInstrumentationBuilder;
 import com.google.dart.tools.ui.internal.preferences.FontPreferencePage;
 import com.google.dart.tools.ui.internal.util.SWTUtil;
 
+import org.eclipse.core.runtime.CoreException;
 import org.eclipse.debug.core.DebugException;
 import org.eclipse.debug.core.DebugPlugin;
 import org.eclipse.debug.core.ILaunch;
+import org.eclipse.debug.core.ILaunchConfiguration;
 import org.eclipse.debug.core.ILaunchesListener2;
 import org.eclipse.debug.core.model.IProcess;
 import org.eclipse.debug.internal.ui.views.console.ProcessConsole;
+import org.eclipse.debug.ui.IDebugUIConstants;
 import org.eclipse.jface.action.Action;
 import org.eclipse.jface.action.IAction;
 import org.eclipse.jface.action.IToolBarManager;
 import org.eclipse.jface.action.Separator;
 import org.eclipse.jface.preference.IPreferenceStore;
 import org.eclipse.jface.preference.PreferenceDialog;
 import org.eclipse.jface.resource.JFaceResources;
 import org.eclipse.jface.util.IPropertyChangeListener;
 import org.eclipse.jface.util.PropertyChangeEvent;
 import org.eclipse.swt.custom.StyledText;
 import org.eclipse.swt.graphics.Font;
 import org.eclipse.swt.widgets.Composite;
 import org.eclipse.swt.widgets.Display;
 import org.eclipse.swt.widgets.Event;
 import org.eclipse.ui.PartInitException;
 import org.eclipse.ui.console.IConsole;
 import org.eclipse.ui.console.IConsoleView;
 import org.eclipse.ui.console.IOConsole;
+import org.eclipse.ui.console.IOConsoleOutputStream;
 import org.eclipse.ui.console.MessageConsole;
 import org.eclipse.ui.console.TextConsole;
 import org.eclipse.ui.dialogs.PreferencesUtil;
 import org.eclipse.ui.internal.console.IOConsolePage;
 import org.eclipse.ui.part.IPageBookViewPage;
 import org.eclipse.ui.part.PageSite;
 import org.eclipse.ui.part.ViewPart;
 import org.eclipse.ui.progress.IWorkbenchSiteProgressService;
 
+import java.io.IOException;
+
 /**
  * An Eclipse view class that displays one and only one IConsole. This is different from the normal
  * ConsoleView which displays n consoles.
  */
 @SuppressWarnings("restriction")
 public class DartConsoleView extends ViewPart implements IConsoleView, IPropertyChangeListener {
 
   private class ClearAction extends InstrumentedAction {
     public ClearAction() {
       super("Clear", Activator.getImageDescriptor("icons/full/eview16/rem_co.gif"));
@@ skipping 242 matching lines @@
 
     updateIcon();
 
     terminateAction.update();
     propertiesAction.setEnabled(getProcess() != null);
 
     // Show cmdline used to launch process
     if (console instanceof ProcessConsole) {
       IProcess process = ((ProcessConsole) console).getProcess();
       openObservatoryAction.updateEnablement(process.getLaunch());
+      showPauseOnStartMessage(process.getLaunch().getLaunchConfiguration());
     }
   }
 
   @Override
   public void dispose() {
     JFaceResources.getFontRegistry().removeListener(fontPropertyChangeListener);
 
     display = null;
 
     DartConsoleManager.getManager().consoleViewClosed(this);
@@ skipping 150 matching lines @@
   private IProcess getProcess() {
     synchronized (consoleLock) {
       if (console instanceof ProcessConsole) {
         return ((ProcessConsole) console).getProcess();
       } else {
         return null;
       }
     }
   }
 
+  private void showPauseOnStartMessage(ILaunchConfiguration config) {
+    try {
+      if (config.getType().getIdentifier().equals(DartDebugCorePlugin.SERVER_LAUNCH_CONFIG_ID)) {
+        DartLaunchConfigWrapper wrapper = new DartLaunchConfigWrapper(config);
+        if (wrapper.getPauseIsolateOnStart()) {
+          IOConsoleOutputStream stream = ((ProcessConsole) getConsole()).getStream(IDebugUIConstants.ID_STANDARD_OUTPUT_STREAM);
+          try {
+            stream.write("Isolate paused on start. Use the Observatory to release it.\n");

[danrubel, 2014/07/14 16:22:17]

How about "Isolate paused on start waiting for Observatory connection. Select
<menu item to select or button to click> to open Observatory and continue
isolate execution." ? Does that correctly capture the current state and what the
user needs to do to move forward?

[keertip, 2014/07/15 07:49:49]

How about "Isolate paused on start. Click on the  \"Open Observatory\" button in
the Toolbar to open Observatory and continue isolate execution." since the wait
is not for Observatoty connection.

On 2014/07/14 16:22:17, danrubel wrote:

[danrubel, 2014/07/15 12:54:57]

Sgtm!

+          } catch (IOException e) {
+            // do nothing
+          }
+        }
+      }
+    } catch (CoreException e) {
+      // do nothing
+    }
+  }
+
   private void updateContentDescription() {
     if (console instanceof ProcessConsole) {
       IProcess process = ((ProcessConsole) console).getProcess();
 
       String configName = process.getLaunch().getLaunchConfiguration().getName();
       String name = "<" + configName + "> ";
 
       if (process.isTerminated()) {
         try {
           name = name + " exit code = " + process.getExitValue();
@@ skipping 48 matching lines @@
     } else {
       toolbar.add(openObservatoryAction);
     }
 
     toolbar.add(terminateAction);
     toolbar.add(new Separator("outputGroup"));
     getViewSite().getActionBars().updateActionBars();
   }
 
 }