Issue 387103004: Revert 282780 because it broke the android-gn build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387103004: Revert 282780 because it broke the android-gn build. (Closed)

Created:
6 years, 5 months ago by sadrul

Modified:
6 years, 5 months ago

Reviewers:
DaleCurtis

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 282780 because it broke the android-gn build. > Enable media in default GN build. > > Roll ffmpeg to pick up build fix. f620cda6 -> 04bb33e9 > > All hail GN. oRZ > > BUG=none > TBR=brettw > > Review URL: https://codereview.chromium.org/381903003 TBR=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282792

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -46 lines)			Patch
M	trunk/src/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/media/BUILD.gn	View	4 chunks	+44 lines, -44 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

Committed patchset #1 manually as r282792 (tree was closed).

6 years, 5 months ago (2014-07-12 04:39:40 UTC) #2

DaleCurtis

6 years, 5 months ago (2014-07-12 17:11:31 UTC) #3

Message was sent while issue was closed.

Thanks! I didn't think it was going to pass the CQ and
forgot to clear the tick, looks like CQ committed it despite failing compile :(

http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...

Expand Messages | Collapse Messages