Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 381903003: Enable media in default GN build. (Closed)

Created:
6 years, 5 months ago by DaleCurtis
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, awong
Project:
chromium
Visibility:
Public.

Description

Enable media in default GN build. Roll ffmpeg to pick up build fix. f620cda6 -> 04bb33e9 All hail GN. oRZ BUG=none TBR=brettw Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282780

Patch Set 1 #

Patch Set 2 : Disable alsa, pulse, ffmpeg on Android. #

Patch Set 3 : Remove duplicate media.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -45 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 2 4 chunks +44 lines, -44 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
DaleCurtis
Stolen from albert. TBR'd since the only change was in the ffmpeg.gyp. I cloned the ...
6 years, 5 months ago (2014-07-11 23:06:36 UTC) #1
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 5 months ago (2014-07-11 23:06:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/381903003/1
6 years, 5 months ago (2014-07-11 23:08:30 UTC) #3
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 5 months ago (2014-07-12 00:08:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/381903003/20001
6 years, 5 months ago (2014-07-12 00:11:32 UTC) #5
DaleCurtis
The CQ bit was unchecked by dalecurtis@chromium.org
6 years, 5 months ago (2014-07-12 00:16:40 UTC) #6
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 5 months ago (2014-07-12 00:17:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/381903003/40001
6 years, 5 months ago (2014-07-12 00:17:48 UTC) #8
DaleCurtis
ack, android compile still needs jni generation targets and unittest setup, fixes shouldn't take too ...
6 years, 5 months ago (2014-07-12 01:20:55 UTC) #9
commit-bot: I haz the power
Change committed as 282780
6 years, 5 months ago (2014-07-12 02:24:03 UTC) #10
sadrul
On 2014/07/12 01:20:55, DaleCurtis wrote: > ack, android compile still needs jni generation targets and ...
6 years, 5 months ago (2014-07-12 04:22:30 UTC) #11
sadrul
On 2014/07/12 04:22:30, sadrul wrote: > On 2014/07/12 01:20:55, DaleCurtis wrote: > > ack, android ...
6 years, 5 months ago (2014-07-12 04:42:36 UTC) #12
DaleCurtis
6 years, 5 months ago (2014-07-12 17:09:48 UTC) #13
Message was sent while issue was closed.
Yeah, it should be reverted, I didn't think it was going to pass the CQ and
forgot to clear the tick, looks like CQ committed it despite failing compile :(

http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...

Powered by Google App Engine
This is Rietveld 408576698