|
|
Created:
6 years, 5 months ago by DaleCurtis Modified:
6 years, 5 months ago Reviewers:
brettw CC:
chromium-reviews, awong Base URL:
svn://svn.chromium.org/chrome/trunk/src Project:
chromium Visibility:
Public. |
DescriptionEnable media in default GN build.
Roll ffmpeg to pick up build fix. f620cda6 -> 04bb33e9
All hail GN. oRZ
BUG=none
TBR=brettw
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282780
Patch Set 1 #Patch Set 2 : Disable alsa, pulse, ffmpeg on Android. #Patch Set 3 : Remove duplicate media.cc #Messages
Total messages: 13 (0 generated)
Stolen from albert. TBR'd since the only change was in the ffmpeg.gyp. I cloned the fix from breakpad.gni.
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/381903003/1
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/381903003/20001
The CQ bit was unchecked by dalecurtis@chromium.org
The CQ bit was checked by dalecurtis@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/381903003/40001
ack, android compile still needs jni generation targets and unittest setup, fixes shouldn't take too long, but will have to wait until monday.
Message was sent while issue was closed.
Change committed as 282780
Message was sent while issue was closed.
On 2014/07/12 01:20:55, DaleCurtis wrote: > ack, android compile still needs jni generation targets and unittest setup, > fixes shouldn't take too long, but will have to wait until monday. Hi. This is breaking the tree: http://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/6033 Should this CL be reverted?
Message was sent while issue was closed.
On 2014/07/12 04:22:30, sadrul wrote: > On 2014/07/12 01:20:55, DaleCurtis wrote: > > ack, android compile still needs jni generation targets and unittest setup, > > fixes shouldn't take too long, but will have to wait until monday. > > Hi. This is breaking the tree: > http://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/6033 > Should this CL be reverted? Parts of the failure log: FAILED: ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/media/midi/media.usb_midi_device_android.o.d -DDISABLE_USER_INPUT_MONITOR -DCHROMIUM_BUILD -DENABLE_NOTIFICATIONS -DENABLE_EGLIMAGE=1 -DENABLE_BACKGROUND=1 -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DCLD_VERSION=1 -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_CONFIGURATION_POLICY -DENABLE_MANAGED_USERS=1 -DENABLE_AUTOFILL_DIALOG=1 -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 -D__GNU_SOURCE=1 -DMEDIA_IMPLEMENTATION -DMEDIA_DISABLE_LIBVPX -DSK_SUPPORT_LEGACY_PICTURE_CLONE -DSK_SUPPORT_LEGACY_GETDEVICE -DSK_IGNORE_ETC1_SUPPORT -DSK_IGNORE_GPU_DITHER -DSK_ENABLE_INST_COUNT=0 -DGR_GL_CUSTOM_SETUP_HEADER=\"GrGLConfig_chrome.h\" -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_SUPPORT_GPU=1 -DSK_USE_POSIX_THREADS -DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -I../../media -I../.. -Igen -I../../third_party/libyuv -I../../third_party/libyuv/include -I../../third_party/openssl/openssl/include -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/src/core -I../../third_party/skia/src/image -I../../third_party/skia/src/opts -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils -I../../third_party/skia/src/lazy -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/opus/src/include -fno-strict-aliasing -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -mthumb-interwork -funwind-tables -fPIC -pipe -ffunction-sections -funwind-tables -fno-short-enums -finline-limit=64 -fno-partial-inlining -fno-early-inlining -fno-tree-copy-prop -fno-tree-loop-optimize -fno-move-loop-invariants -fno-caller-saves -Wall -Werror -Wsign-compare -Wendif-labels -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-extra -Wno-ignored-qualifiers -Wno-type-limits -Wno-unused-local-typedefs -isystem../../third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport -fvisibility=hidden --sysroot=/b/build/slave/Android_GN/build/src/third_party/android_tools/ndk/platforms/android-14/arch-arm -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -Os -g2 -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor -Wno-sign-promo -fno-rtti -fno-exceptions -c ../../media/midi/usb_midi_device_android.cc -o obj/media/midi/media.usb_midi_device_android.o ../../media/midi/usb_midi_device_android.cc:12:42: fatal error: jni/UsbMidiDeviceAndroid_jni.h: No such file or directory #include "jni/UsbMidiDeviceAndroid_jni.h" ^ compilation terminated. FAILED: ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/media/audio/android/media.audio_manager_android.o.d -DDISABLE_USER_INPUT_MONITOR -DCHROMIUM_BUILD -DENABLE_NOTIFICATIONS -DENABLE_EGLIMAGE=1 -DENABLE_BACKGROUND=1 -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DCLD_VERSION=1 -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_CONFIGURATION_POLICY -DENABLE_MANAGED_USERS=1 -DENABLE_AUTOFILL_DIALOG=1 -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 -D__GNU_SOURCE=1 -DMEDIA_IMPLEMENTATION -DMEDIA_DISABLE_LIBVPX -DSK_SUPPORT_LEGACY_PICTURE_CLONE -DSK_SUPPORT_LEGACY_GETDEVICE -DSK_IGNORE_ETC1_SUPPORT -DSK_IGNORE_GPU_DITHER -DSK_ENABLE_INST_COUNT=0 -DGR_GL_CUSTOM_SETUP_HEADER=\"GrGLConfig_chrome.h\" -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_SUPPORT_GPU=1 -DSK_USE_POSIX_THREADS -DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -I../../media -I../.. -Igen -I../../third_party/libyuv -I../../third_party/libyuv/include -I../../third_party/openssl/openssl/include -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/src/core -I../../third_party/skia/src/image -I../../third_party/skia/src/opts -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils -I../../third_party/skia/src/lazy -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/opus/src/include -fno-strict-aliasing -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -mthumb-interwork -funwind-tables -fPIC -pipe -ffunction-sections -funwind-tables -fno-short-enums -finline-limit=64 -fno-partial-inlining -fno-early-inlining -fno-tree-copy-prop -fno-tree-loop-optimize -fno-move-loop-invariants -fno-caller-saves -Wall -Werror -Wsign-compare -Wendif-labels -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-extra -Wno-ignored-qualifiers -Wno-type-limits -Wno-unused-local-typedefs -isystem../../third_party/android_tools/ndk/sources/cxx-stl/stlport/stlport -fvisibility=hidden --sysroot=/b/build/slave/Android_GN/build/src/third_party/android_tools/ndk/platforms/android-14/arch-arm -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -Os -g2 -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor -Wno-sign-promo -fno-rtti -fno-exceptions -c ../../media/audio/android/audio_manager_android.cc -o obj/media/audio/android/media.audio_manager_android.o ../../media/audio/android/audio_manager_android.cc:14:41: fatal error: jni/AudioManagerAndroid_jni.h: No such file or directory #include "jni/AudioManagerAndroid_jni.h" ^ compilation terminated.
Message was sent while issue was closed.
Yeah, it should be reverted, I didn't think it was going to pass the CQ and forgot to clear the tick, looks like CQ committed it despite failing compile :( http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c... |