Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: trunk/src/media/BUILD.gn

Issue 387103004: Revert 282780 because it broke the android-gn build. (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/media/BUILD.gn
===================================================================
--- trunk/src/media/BUILD.gn (revision 282791)
+++ trunk/src/media/BUILD.gn (working copy)
@@ -31,7 +31,7 @@
# Original conditional: (OS=="linux" or OS=="freebsd" or OS=="solaris") and embedded!=1
use_alsa = false
use_pulseaudio = false
-if (is_posix && !is_android) {
+if (is_posix) {
use_alsa = true
if (!use_cras) {
use_pulseaudio = true
@@ -595,6 +595,8 @@
"base/android/media_player_manager.h",
"base/android/media_resource_getter.cc",
"base/android/media_resource_getter.h",
+ "base/media.cc",
+ "base/media.h",
"base/media_stub.cc",
"midi/midi_manager_android.cc",
"midi/usb_midi_device_android.cc",
@@ -620,7 +622,7 @@
if (is_chromeos) {
# A simple WebM encoder for animated avatars on ChromeOS.
- sources += [
+ sources += [
"formats/webm/chromeos/ebml_writer.cc",
"formats/webm/chromeos/ebml_writer.h",
"formats/webm/chromeos/webm_encoder.cc",
@@ -1286,50 +1288,48 @@
deps = [ "//base" ]
}
-if (media_use_ffmpeg) {
- test("ffmpeg_unittests") {
- sources = [ "ffmpeg/ffmpeg_unittest.cc" ]
+test("ffmpeg_unittests") {
+ sources = [ "ffmpeg/ffmpeg_unittest.cc" ]
- deps = [
- ":media",
- ":media_test_support",
- "//base",
- "//base:i18n",
- "//base/test:test_support",
- "//testing/gtest",
- "//third_party/ffmpeg",
- "//ui/gfx:gfx_test_support",
- ]
- }
+ deps = [
+ ":media",
+ ":media_test_support",
+ "//base",
+ "//base:i18n",
+ "//base/test:test_support",
+ "//testing/gtest",
+ "//third_party/ffmpeg",
+ "//ui/gfx:gfx_test_support",
+ ]
+}
- test("ffmpeg_regression_tests") {
- sources = [
- "base/run_all_unittests.cc",
- "ffmpeg/ffmpeg_regression_tests.cc",
- "filters/pipeline_integration_test_base.cc",
- ]
- configs += [ ":media_config" ]
- deps = [
- ":media",
- ":media_test_support",
- "//base/test:test_support",
- "//testing/gmock",
- "//testing/gtest",
- "//third_party/ffmpeg",
- "//ui/gfx/geometry",
- "//ui/gfx:gfx_test_support",
- ]
- # TODO(ajwong): This was in the original gyp, but it seems silly.
- # ['os_posix==1 and OS!="mac"', {
- # 'conditions': [
- # ['use_allocator!="none"', {
- # 'dependencies': [
- # '../base/allocator/allocator.gyp:allocator',
- # ],
- # }],
- # ],
- # }],
- }
+test("ffmpeg_regression_tests") {
+ sources = [
+ "base/run_all_unittests.cc",
+ "ffmpeg/ffmpeg_regression_tests.cc",
+ "filters/pipeline_integration_test_base.cc",
+ ]
+ configs += [ ":media_config" ]
+ deps = [
+ ":media",
+ ":media_test_support",
+ "//base/test:test_support",
+ "//testing/gmock",
+ "//testing/gtest",
+ "//third_party/ffmpeg",
+ "//ui/gfx/geometry",
+ "//ui/gfx:gfx_test_support",
+ ]
+# TODO(ajwong): This was in the original gyp, but it seems silly.
+# ['os_posix==1 and OS!="mac"', {
+# 'conditions': [
+# ['use_allocator!="none"', {
+# 'dependencies': [
+# '../base/allocator/allocator.gyp:allocator',
+# ],
+# }],
+# ],
+# }],
}
if (use_x11) {
« no previous file with comments | « trunk/src/DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698