Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Unified Diff: runtime/vm/stub_code_mips.cc

Issue 387063002: Moves infrequently used debugger code in CheckInlineCachestub. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/stub_code_mips.cc
===================================================================
--- runtime/vm/stub_code_mips.cc (revision 38158)
+++ runtime/vm/stub_code_mips.cc (working copy)
@@ -1405,23 +1405,13 @@
#endif // DEBUG
+ Label stepping, done_stepping;
if (FLAG_enable_debugger) {
// Check single stepping.
- Label not_stepping;
__ lw(T0, FieldAddress(CTX, Context::isolate_offset()));
__ lbu(T0, Address(T0, Isolate::single_step_offset()));
- __ BranchEqual(T0, 0, &not_stepping);
- // Call single step callback in debugger.
- __ EnterStubFrame();
- __ addiu(SP, SP, Immediate(-2 * kWordSize));
- __ sw(S5, Address(SP, 1 * kWordSize)); // Preserve IC data.
- __ sw(RA, Address(SP, 0 * kWordSize)); // Return address.
- __ CallRuntime(kSingleStepHandlerRuntimeEntry, 0);
- __ lw(RA, Address(SP, 0 * kWordSize));
- __ lw(S5, Address(SP, 1 * kWordSize));
- __ addiu(SP, SP, Immediate(2 * kWordSize));
- __ LeaveStubFrame();
- __ Bind(&not_stepping);
+ __ BranchNotEqual(T0, 0, &stepping);
+ __ Bind(&done_stepping);
}
// Load argument descriptor into S4.
@@ -1556,6 +1546,21 @@
__ lw(T4, FieldAddress(T0, Function::instructions_offset()));
__ AddImmediate(T4, Instructions::HeaderSize() - kHeapObjectTag);
__ jr(T4);
+
+ if (FLAG_enable_debugger) {
+ // Call single step callback in debugger.
+ __ Bind(&stepping);
+ __ EnterStubFrame();
+ __ addiu(SP, SP, Immediate(-2 * kWordSize));
+ __ sw(S5, Address(SP, 1 * kWordSize)); // Preserve IC data.
+ __ sw(RA, Address(SP, 0 * kWordSize)); // Return address.
+ __ CallRuntime(kSingleStepHandlerRuntimeEntry, 0);
+ __ lw(RA, Address(SP, 0 * kWordSize));
+ __ lw(S5, Address(SP, 1 * kWordSize));
+ __ addiu(SP, SP, Immediate(2 * kWordSize));
+ __ LeaveStubFrame();
+ __ b(&done_stepping);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698