Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: runtime/vm/stub_code_x64.cc

Issue 387063002: Moves infrequently used debugger code in CheckInlineCachestub. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/stub_code_ia32.cc ('K') | « runtime/vm/stub_code_mips.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_x64.cc
===================================================================
--- runtime/vm/stub_code_x64.cc (revision 38158)
+++ runtime/vm/stub_code_x64.cc (working copy)
@@ -1268,19 +1268,14 @@
}
#endif // DEBUG
+ Label stepping, done_stepping;
if (FLAG_enable_debugger) {
// Check single stepping.
- Label not_stepping;
__ movq(RAX, FieldAddress(CTX, Context::isolate_offset()));
__ movzxb(RAX, Address(RAX, Isolate::single_step_offset()));
__ cmpq(RAX, Immediate(0));
- __ j(EQUAL, &not_stepping, Assembler::kNearJump);
- __ EnterStubFrame();
- __ pushq(RBX);
- __ CallRuntime(kSingleStepHandlerRuntimeEntry, 0);
- __ popq(RBX);
- __ LeaveStubFrame();
- __ Bind(&not_stepping);
+ __ j(NOT_EQUAL, &stepping);
+ __ Bind(&done_stepping);
}
// Load arguments descriptor into R10.
@@ -1384,6 +1379,16 @@
__ movq(RCX, FieldAddress(RAX, Function::instructions_offset()));
__ addq(RCX, Immediate(Instructions::HeaderSize() - kHeapObjectTag));
__ jmp(RCX);
+
+ if (FLAG_enable_debugger) {
+ __ Bind(&stepping);
+ __ EnterStubFrame();
+ __ pushq(RBX);
+ __ CallRuntime(kSingleStepHandlerRuntimeEntry, 0);
+ __ popq(RBX);
+ __ LeaveStubFrame();
+ __ jmp(&done_stepping);
+ }
}
« runtime/vm/stub_code_ia32.cc ('K') | « runtime/vm/stub_code_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698