Issue 387043002: No need to cache local matrix in picture shader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 387043002: No need to cache local matrix in picture shader. (Closed)

Created:
6 years, 5 months ago by scroggo

Modified:
6 years, 5 months ago

Reviewers:
f(malita), fmalita_google_do_not_use

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

No need to cache local matrix in picture shader. Now that the local matrix cannot be changed, we no longer need to keep track of it to regenerate the bitmap shader. Depends on https://codereview.chromium.org/379323002 Committed: https://skia.googlesource.com/skia/+/1b0aa001e8f5245663965992f32df6a43cb22e2f

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	src/core/SkPictureShader.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/core/SkPictureShader.cpp	View		2 chunks	+1 line, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/387043002/1

6 years, 5 months ago (2014-07-11 18:44:33 UTC) #4

commit-bot: I haz the power

6 years, 5 months ago (2014-07-11 19:19:07 UTC) #5

Message was sent while issue was closed.

Change committed as 1b0aa001e8f5245663965992f32df6a43cb22e2f