Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 379323002: Remove SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX. (Closed)

Created:
6 years, 5 months ago by scroggo
Modified:
6 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX. This is no longer needed by Android. BUG=skia:1976 Committed: https://skia.googlesource.com/skia/+/ef0fd61dc2ea50ce29b1fe0feed473479b32e42c

Patch Set 1 #

Patch Set 2 : Comment about const-ness of fLocalMatrix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkShader.h View 1 2 chunks +2 lines, -13 lines 0 comments Download
M src/core/SkPaintPriv.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
Not quite ready for this, but should be soon. (I have to debug why my ...
6 years, 5 months ago (2014-07-09 22:19:34 UTC) #1
reed1
lgtm
6 years, 5 months ago (2014-07-10 14:03:30 UTC) #2
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 5 months ago (2014-07-11 18:17:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/379323002/20001
6 years, 5 months ago (2014-07-11 18:18:03 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 18:33:56 UTC) #5
Message was sent while issue was closed.
Change committed as ef0fd61dc2ea50ce29b1fe0feed473479b32e42c

Powered by Google App Engine
This is Rietveld 408576698