Correct the usage of finalize in TracingControllerAndroid class.

Correct the usage of finalize in TracingControllerAndroid class.

TracingControllerAndroid should destroy its native instance when it
is done instead of relying on finalize() to destroy it, as vm does
not guaranteed finalize() will be called.
(source: http://docs.oracle.com/javase/7/docs/api/java/lang/Object.html#finalize%28%29)

Implement destroy() to immediately destroy native instance.

BUG=None.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283177

[wajahat, 2014-07-11 13:10:54]

The CQ bit was checked by wajahat.s@samsung.com

[wajahat, 2014-07-11 13:10:55]

The CQ bit was unchecked by wajahat.s@samsung.com

[wajahat, 2014-07-11 13:18:42]

Please review, Thanks!

[wajahat, 2014-07-14 06:56:20]

PTAL!

[Sami, 2014-07-14 09:46:50]

https://codereview.chromium.org/386983002/diff/1/content/public/android/javat...
File
content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java
(right):

https://codereview.chromium.org/386983002/diff/1/content/public/android/javat...
content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java:64:
// destroy native tracing controller objects.
nit: This comment could be removed.

https://codereview.chromium.org/386983002/diff/1/content/public/android/javat...
content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java:65:
if (!tracingController.isTracing()) {
No need for this check because of the while-loop above, right?

[wajahat, 2014-07-14 10:04:13]

@Sami, Thanks for review !
Changes Incorporated
PTAL!

https://codereview.chromium.org/386983002/diff/1/content/public/android/javat...
File
content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java
(right):

https://codereview.chromium.org/386983002/diff/1/content/public/android/javat...
content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java:64:
// destroy native tracing controller objects.
On 2014/07/14 09:46:49, Sami wrote:
> nit: This comment could be removed.

Done.

https://codereview.chromium.org/386983002/diff/1/content/public/android/javat...
content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java:65:
if (!tracingController.isTracing()) {
On 2014/07/14 09:46:49, Sami wrote:
> No need for this check because of the while-loop above, right?

Done.

[Sami, 2014-07-14 10:14:19]

Thank you, lgtm.

[wajahat, 2014-07-14 10:29:40]

The CQ bit was checked by wajahat.s@samsung.com

[commit-bot: I haz the power, 2014-07-14 10:30:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wajahat.s@samsung.com/386983002/20001

[wajahat, 2014-07-14 10:45:50]

The CQ bit was unchecked by wajahat.s@samsung.com

[wajahat, 2014-07-14 10:59:12]

Presubmit failed due, 
Missing LGTM from an OWNER for these files:
content/public/android/java/src/org/chromium/content/app/ContentApplication.java
(benm, tedchoc, yfriedman)
   
content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java
(jdduke)
   
content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java
(jdduke)
PTAL, Thanks!

[jdduke (slow), 2014-07-14 15:11:08]

On 2014/07/14 10:59:12, wajahat wrote:
> Presubmit failed due, 
> Missing LGTM from an OWNER for these files:
>
content/public/android/java/src/org/chromium/content/app/ContentApplication.java
> (benm, tedchoc, yfriedman)
>    
>
content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java
> (jdduke)
>    
>
content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java
> (jdduke)
> PTAL, Thanks!

I'm technically only an owner for input-related changes. Also, in the future
please only add a minimal subset of owners for reviewing your patch. This
minimizes the review burden and avoids confusion about who should review which
changes (e.g., in this patchset, it would be sufficient to add just one of benm@
OR tedchcoc@ OR @yfriedman, not all 3, and any one of them is also an owner for
the changes in content/browser).

I've found this Chrome extension
(https://chrome.google.com/webstore/detail/chromite-butler/bhcnanendmgjjeghama...)
to be useful in making clear which files in a patchset either require an LGTM or
an additional OWNER in the reviewer list. Hopefully that helps, and thanks for
your contribution.

[Yaron, 2014-07-14 15:54:21]

lgtm

[wajahat, 2014-07-15 05:16:39]

The CQ bit was checked by wajahat.s@samsung.com

[commit-bot: I haz the power, 2014-07-15 05:17:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wajahat.s@samsung.com/386983002/20001

[commit-bot: I haz the power, 2014-07-15 10:29:48]

Change committed as 283177

[wajahat, 2014-08-27 14:59:29]

Patchset #3 (id:40001) has been deleted