Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Side by Side Diff: content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java

Issue 386983002: Correct the usage of finalize in TracingControllerAndroid class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated as per comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.content.browser; 5 package org.chromium.content.browser;
6 6
7 import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout; 7 import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout;
8 8
9 import android.os.SystemClock; 9 import android.os.SystemClock;
10 import android.test.suitebuilder.annotation.MediumTest; 10 import android.test.suitebuilder.annotation.MediumTest;
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
54 while (tracingController.isTracing()) { 54 while (tracingController.isTracing()) {
55 if (SystemClock.uptimeMillis() > startTime + TIMEOUT_MILLIS) { 55 if (SystemClock.uptimeMillis() > startTime + TIMEOUT_MILLIS) {
56 fail("Timed out waiting for tracing to stop."); 56 fail("Timed out waiting for tracing to stop.");
57 } 57 }
58 Thread.sleep(1000); 58 Thread.sleep(1000);
59 } 59 }
60 60
61 // It says it stopped, so it should have written the output file. 61 // It says it stopped, so it should have written the output file.
62 assertTrue(file.exists()); 62 assertTrue(file.exists());
63 assertTrue(file.delete()); 63 assertTrue(file.delete());
64 tracingController.destroy();
64 } 65 }
65 } 66 }
OLDNEW
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698