content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java - Issue 386983002: Correct the usage of finalize in TracingControllerAndroid class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java

Issue 386983002: Correct the usage of finalize in TracingControllerAndroid class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated as per comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/app/ContentApplication.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java b/content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java

index b89205c7a688230a9fdc5c9e38f97c400ceb3c39..514ab6ae324d36872a47248a1e149b9712789aa7 100644

--- a/content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java

+++ b/content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java

@@ -242,6 +242,15 @@ public class TracingControllerAndroid {

@Override

protected void finalize() {

+ // Ensure that destroy() was called.

+ assert mNativeTracingControllerAndroid == 0;

+ }

+ /**

+ * Clean up the C++ side of this class.

+ * After the call, this class instance shouldn't be used.

+ */

+ public void destroy() {

if (mNativeTracingControllerAndroid != 0) {

nativeDestroy(mNativeTracingControllerAndroid);

mNativeTracingControllerAndroid = 0;