Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 386933004: Revert of Add alternate SkPicture::clone (Closed)

Created:
6 years, 5 months ago by robertphillips
Modified:
6 years, 5 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Add alternate SkPicture::clone (https://codereview.chromium.org/381193002/) Reason for revert: Going to try to just remove the many-at-once clone interface Original issue's description: > Add alternate SkPicture::clone > > This adds an alternate version of SkPicture::clone for two reasons: > > 1) Chromium uses the SkPicture copy constructor to unpack the pictures from the old-style clone interface (and I would like to remove the copy ctor) > > 2) This is part of the long term plan to wean Chrome off of cloning. Once pictures are thread safe we will switch the new SkPicture::clone call to just return 'this'. From there it is a small step to removing clone entirely. > > Note that the two versions of clone() is temporary. Once this is landed (and rolled) I will land a Chrome-side patch to remove their use of the old interface (Use new SkPicture::clone interface - https://codereview.chromium.org/380323002/) > > Committed: https://skia.googlesource.com/skia/+/e372e78223a8ce916d276d6e0420d552fb0267e9 TBR=mtklein@google.com,reed@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/ffc75efc1a4c231286c773ff090ec84fc16e9422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -69 lines) Patch
M include/core/SkPicture.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkPicture.cpp View 2 chunks +2 lines, -68 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
Created Revert of Add alternate SkPicture::clone
6 years, 5 months ago (2014-07-11 13:45:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/386933004/1
6 years, 5 months ago (2014-07-11 13:45:55 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 13:46:01 UTC) #3
Message was sent while issue was closed.
Change committed as ffc75efc1a4c231286c773ff090ec84fc16e9422

Powered by Google App Engine
This is Rietveld 408576698