Implement reflected attributes of HTMLMarqueeElement in Blink-in-JS

Implement reflected attributes of HTMLMarqueeElement in Blink-in-JS

This CL implements HTMLMarqueeElement.{behavior,bgColor,direction,height,hspace,trueSpeed,vspace,width} in Blink-in-JS.

This CL doesn't remove any code from C++ since reflected attributes don't have corresponding code in C++.

BUG=341031
TEST=fast/dom/marquee-element.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178043

[haraken, 2014-07-14 04:58:56]

abarth@, arv@: PTAL.

[haraken, 2014-07-14 05:01:51]

https://codereview.chromium.org/386353002/diff/20001/Source/bindings/core/v8/...
File Source/bindings/core/v8/PrivateScriptRunner.cpp (right):

https://codereview.chromium.org/386353002/diff/20001/Source/bindings/core/v8/...
Source/bindings/core/v8/PrivateScriptRunner.cpp:95: v8::Handle<v8::Value>
initializeFunction = classObject->Get(v8String(isolate, "initialize"));

I renamed 'constructor' to 'initialize', since 'constructor' is a built-in
function and can cause some unexpected conflict. For example, the following code
causes TypeError.

  var HTMLMarqueeElementPrototype = Object.create(HTMLElement.prototype);
  HTMLMarqueeElementPrototype.constructor;  // function () { [native code] }
  HTMLMarqueeElementPrototype.constructor(); // Type error: Illegal constructor

[abarth-chromium, 2014-07-14 06:04:35]

LGTM

https://codereview.chromium.org/386353002/diff/20001/Source/bindings/scripts/...
File Source/bindings/scripts/v8_types.py (right):

https://codereview.chromium.org/386353002/diff/20001/Source/bindings/scripts/...
Source/bindings/scripts/v8_types.py:542: cpp_value = 'std::max(0, int(%s))' %
cpp_value
static_cast<int>(...)

https://codereview.chromium.org/386353002/diff/20001/Source/core/html/HTMLMar...
File Source/core/html/HTMLMarqueeElement.js (right):

https://codereview.chromium.org/386353002/diff/20001/Source/core/html/HTMLMar...
Source/core/html/HTMLMarqueeElement.js:65: if (Boolean(value) === false)
Does this call valueOf?  Are we supposed to call valueOf?

https://codereview.chromium.org/386353002/diff/20001/Source/core/html/HTMLMar...
Source/core/html/HTMLMarqueeElement.js:65: if (Boolean(value) === false)
Does this call valueOf?  Are we supposed to call valueOf?

[abarth-chromium, 2014-07-14 06:05:18]

https://codereview.chromium.org/386353002/diff/20001/Source/core/html/HTMLMar...
File Source/core/html/HTMLMarqueeElement.idl (right):

https://codereview.chromium.org/386353002/diff/20001/Source/core/html/HTMLMar...
Source/core/html/HTMLMarqueeElement.idl:28: [ImplementedInPrivateScript,
Reflect] attribute unsigned long hspace;
Does |Reflect| do anything here anymore?

[haraken, 2014-07-14 09:59:12]

https://codereview.chromium.org/386353002/diff/20001/Source/bindings/scripts/...
File Source/bindings/scripts/v8_types.py (right):

https://codereview.chromium.org/386353002/diff/20001/Source/bindings/scripts/...
Source/bindings/scripts/v8_types.py:542: cpp_value = 'std::max(0, int(%s))' %
cpp_value
On 2014/07/14 06:04:35, abarth wrote:
> static_cast<int>(...)

Done.

https://codereview.chromium.org/386353002/diff/20001/Source/core/html/HTMLMar...
File Source/core/html/HTMLMarqueeElement.idl (right):

https://codereview.chromium.org/386353002/diff/20001/Source/core/html/HTMLMar...
Source/core/html/HTMLMarqueeElement.idl:28: [ImplementedInPrivateScript,
Reflect] attribute unsigned long hspace;
On 2014/07/14 06:05:18, abarth wrote:
> Does |Reflect| do anything here anymore?

[Reflect] is still needed, since we generate [Reflect]-specific code. For
example, reflected unsigned long attributes needs to return std::max(0,
static_cast<int>(value)) instead of |value|.

https://codereview.chromium.org/386353002/diff/20001/Source/core/html/HTMLMar...
File Source/core/html/HTMLMarqueeElement.js (right):

https://codereview.chromium.org/386353002/diff/20001/Source/core/html/HTMLMar...
Source/core/html/HTMLMarqueeElement.js:65: if (Boolean(value) === false)
On 2014/07/14 06:04:35, abarth wrote:
> Does this call valueOf?  Are we supposed to call valueOf?

Done.

[haraken, 2014-07-14 10:00:19]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-07-14 10:01:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/386353002/40001

[commit-bot: I haz the power, 2014-07-14 11:04:12]

Change committed as 178043

[arv (Not doing code reviews), 2014-07-14 14:49:09]

https://codereview.chromium.org/386353002/diff/40001/Source/core/html/HTMLMar...
File Source/core/html/HTMLMarqueeElement.js (right):

https://codereview.chromium.org/386353002/diff/40001/Source/core/html/HTMLMar...
Source/core/html/HTMLMarqueeElement.js:65: if (value.valueOf() === false)
This will fail when set to null or undefined.

The boolean reflect is just falsey so this should be:

if (!value) {

(Using .valueOf() is most likely a bug. Real code hardly ever uses it.)

https://codereview.chromium.org/386353002/diff/40001/Source/core/html/HTMLMar...
Source/core/html/HTMLMarqueeElement.js:68: this.setAttribute(attributeName,
value ? '' : null);
You already handled the the falsey case.

this.setAttribute(attributeName, '');