Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 386353002: Implement reflected attributes of HTMLMarqueeElement in Blink-in-JS (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/attributes.cpp
diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp
index e65de18eb7873450395e18bffaea4f6c5cff498e..6b0335abbe8629bf4ae923e71abd154bfdc13ed6 100644
--- a/Source/bindings/templates/attributes.cpp
+++ b/Source/bindings/templates/attributes.cpp
@@ -8,8 +8,9 @@ const v8::FunctionCallbackInfo<v8::Value>& info
const v8::PropertyCallbackInfo<v8::Value>& info
{%- endif %})
{
- {% if attribute.is_reflect and not attribute.is_url and
- attribute.idl_type == 'DOMString' and is_node %}
+ {% if attribute.is_reflect and not attribute.is_url
+ and attribute.idl_type == 'DOMString' and is_node
+ and not attribute.is_implemented_in_private_script %}
{% set cpp_class, v8_class = 'Element', 'V8Element' %}
{% endif %}
{# holder #}
@@ -201,8 +202,8 @@ v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info
v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info
{%- endif %})
{
- {% if attribute.is_reflect and attribute.idl_type == 'DOMString' and
- is_node %}
+ {% if attribute.is_reflect and attribute.idl_type == 'DOMString'
+ and is_node and not attribute.is_implemented_in_private_script %}
{% set cpp_class, v8_class = 'Element', 'V8Element' %}
{% endif %}
{# Local variables #}

Powered by Google App Engine
This is Rietveld 408576698