Update files in telemetry/page/ to use results.AddValue()

Update files in telemetry/page/ to use results.AddValue()

TBR=nduca@chromium.org
BUG=346958
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282725

[chrishenry, 2014-07-11 18:14:25]

lgtm in advance, but see comments below.

https://codereview.chromium.org/385253002/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_measurement.py (right):

https://codereview.chromium.org/385253002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_measurement.py:23:
results.AddValue(scalar.ScalarValue(
No import for scalar?

https://codereview.chromium.org/385253002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_measurement.py:24: results.current_page,
'body_children', 'count', body_child_count))
Can't this simply be "page"? Same elsewhere.

https://codereview.chromium.org/385253002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_measurement.py:24: results.current_page,
'body_children', 'count', body_child_count))
nit: 4-align, same for every change below.

[chrishenry, 2014-07-11 18:17:12]

https://codereview.chromium.org/385253002/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_measurement.py (right):

https://codereview.chromium.org/385253002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_measurement.py:23:
results.AddValue(scalar.ScalarValue(
On 2014/07/11 18:14:24, chrishenry wrote:
> No import for scalar?

Ned pointed out this is docstring, ignore this comment. (Sigh, stupid
highlighter.)

[nednguyen, 2014-07-11 18:29:08]

https://codereview.chromium.org/385253002/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/page_measurement.py (right):

https://codereview.chromium.org/385253002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_measurement.py:24: results.current_page,
'body_children', 'count', body_child_count))
On 2014/07/11 18:14:24, chrishenry wrote:
> Can't this simply be "page"? Same elsewhere.
Done.

Damn, this needs to be fixed everywhere too. Maybe after crbug.com/391943 is
fixed.

https://codereview.chromium.org/385253002/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/page_measurement.py:24: results.current_page,
'body_children', 'count', body_child_count))
On 2014/07/11 18:14:24, chrishenry wrote:
> nit: 4-align, same for every change below.

Done.

[nednguyen, 2014-07-11 18:29:14]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2014-07-11 18:29:40]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2014-07-11 18:31:52]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-07-11 18:32:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/385253002/40001

[commit-bot: I haz the power, 2014-07-11 18:32:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-11 18:32:58]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[nednguyen, 2014-07-11 19:24:48]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-07-11 19:27:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nednguyen@google.com/385253002/40001

[commit-bot: I haz the power, 2014-07-11 23:15:54]

Change committed as 282725