tools/telemetry/telemetry/page/page_measurement_unittest.py - Issue 385253002: Update files in telemetry/page/ to use results.AddValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_measurement_unittest.py

Issue 385253002: Update files in telemetry/page/ to use results.AddValue() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/page_measurement_unittest.py

diff --git a/tools/telemetry/telemetry/page/page_measurement_unittest.py b/tools/telemetry/telemetry/page/page_measurement_unittest.py

index e30155e6026de2594f9967487de3299f160fc2a1..33ccb983db9a9a2b0c645e72265a7974672dcf48 100644

--- a/tools/telemetry/telemetry/page/page_measurement_unittest.py

+++ b/tools/telemetry/telemetry/page/page_measurement_unittest.py

@@ -14,6 +14,7 @@ from telemetry.page import page_measurement_unittest_base

from telemetry.page import page_set

from telemetry.page import page_set_archive_info

from telemetry.unittest import options_for_unittests

+from telemetry.value import scalar

class MeasurementThatFails(page_measurement.PageMeasurement):

@@ -30,7 +31,7 @@ class MeasurementThatHasDefaults(page_measurement.PageMeasurement):

if self.options.x != 3:

raise page_measurement.MeasurementFailure(

'Expected x == 3, got x == ' + self.options.x)

- results.Add('x', 'ms', 7)

+ results.AddValue(scalar.ScalarValue(page, 'x', 'ms', 7))

class MeasurementForBlank(page_measurement.PageMeasurement):

def MeasurePage(self, page, tab, results):

« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement.py ('k') | tools/telemetry/telemetry/page/page_runner_unittest.py » ('j') | no next file with comments »