Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 385253002: Update files in telemetry/page/ to use results.AddValue() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_runner_unittest.py b/tools/telemetry/telemetry/page/page_runner_unittest.py
index deaa6140c55544c3425991fa7f839b2019be8eb2..5797c75e4984366e75f21a801349485719004301 100644
--- a/tools/telemetry/telemetry/page/page_runner_unittest.py
+++ b/tools/telemetry/telemetry/page/page_runner_unittest.py
@@ -19,6 +19,7 @@ from telemetry.page import page_test
from telemetry.page import page_runner
from telemetry.page import test_expectations
from telemetry.unittest import options_for_unittests
+from telemetry.value import scalar
SIMPLE_CREDENTIALS_STRING = """
@@ -213,9 +214,10 @@ class PageRunnerTests(unittest.TestCase):
class Measurement(page_measurement.PageMeasurement):
i = 0
- def MeasurePage(self, _1, _2, results):
+ def MeasurePage(self, page, _, results):
self.i += 1
- results.Add('metric', 'unit', self.i)
+ results.AddValue(scalar.ScalarValue(
+ page, 'metric', 'unit', self.i))
output_file = tempfile.NamedTemporaryFile(delete=False).name
try:
« no previous file with comments | « tools/telemetry/telemetry/page/page_measurement_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698