Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 385173009: Remove ASSERT since there are tons of different ASSIGN variants (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove ASSERT since there are tons of different ASSIGN variants BUG= R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-14 14:42:04 UTC) #1
rossberg
lgtm
6 years, 5 months ago (2014-07-14 14:42:17 UTC) #2
Toon Verwaest
6 years, 5 months ago (2014-07-14 14:42:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22382 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698