Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 385173009: Remove ASSERT since there are tons of different ASSIGN variants (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 2484 matching lines...) Expand 10 before | Expand all | Expand 10 after
2495 __ b(ne, &assign); 2495 __ b(ne, &assign);
2496 __ mov(r3, Operand(var->name())); 2496 __ mov(r3, Operand(var->name()));
2497 __ push(r3); 2497 __ push(r3);
2498 __ CallRuntime(Runtime::kThrowReferenceError, 1); 2498 __ CallRuntime(Runtime::kThrowReferenceError, 1);
2499 // Perform the assignment. 2499 // Perform the assignment.
2500 __ bind(&assign); 2500 __ bind(&assign);
2501 EmitStoreToStackLocalOrContextSlot(var, location); 2501 EmitStoreToStackLocalOrContextSlot(var, location);
2502 2502
2503 } else if (!var->is_const_mode() || op == Token::INIT_CONST) { 2503 } else if (!var->is_const_mode() || op == Token::INIT_CONST) {
2504 if (var->IsLookupSlot()) { 2504 if (var->IsLookupSlot()) {
2505 ASSERT(op == Token::ASSIGN || op == Token::INIT_VAR ||
2506 op == Token::ASSIGN_ADD);
2507 // Assignment to var. 2505 // Assignment to var.
2508 __ push(r0); // Value. 2506 __ push(r0); // Value.
2509 __ mov(r1, Operand(var->name())); 2507 __ mov(r1, Operand(var->name()));
2510 __ mov(r0, Operand(Smi::FromInt(strict_mode()))); 2508 __ mov(r0, Operand(Smi::FromInt(strict_mode())));
2511 __ Push(cp, r1, r0); // Context, name, strict mode. 2509 __ Push(cp, r1, r0); // Context, name, strict mode.
2512 __ CallRuntime(Runtime::kStoreLookupSlot, 4); 2510 __ CallRuntime(Runtime::kStoreLookupSlot, 4);
2513 } else { 2511 } else {
2514 // Assignment to var or initializing assignment to let/const in harmony 2512 // Assignment to var or initializing assignment to let/const in harmony
2515 // mode. 2513 // mode.
2516 ASSERT((var->IsStackAllocated() || var->IsContextSlot())); 2514 ASSERT((var->IsStackAllocated() || var->IsContextSlot()));
(...skipping 2339 matching lines...) Expand 10 before | Expand all | Expand 10 after
4856 4854
4857 ASSERT(interrupt_address == 4855 ASSERT(interrupt_address ==
4858 isolate->builtins()->OsrAfterStackCheck()->entry()); 4856 isolate->builtins()->OsrAfterStackCheck()->entry());
4859 return OSR_AFTER_STACK_CHECK; 4857 return OSR_AFTER_STACK_CHECK;
4860 } 4858 }
4861 4859
4862 4860
4863 } } // namespace v8::internal 4861 } } // namespace v8::internal
4864 4862
4865 #endif // V8_TARGET_ARCH_ARM 4863 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698