src/ia32/full-codegen-ia32.cc - Issue 385173009: Remove ASSERT since there are tons of different ASSIGN variants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 385173009: Remove ASSERT since there are tons of different ASSIGN variants (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index 8ab2d3017ff9405f272d008dbb0e4fa7fcd01622..0dc3254921bbf99ad586a41530c770303101550b 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -2428,8 +2428,6 @@ void FullCodeGenerator::EmitVariableAssignment(Variable* var,

} else if (!var->is_const_mode() || op == Token::INIT_CONST) {

if (var->IsLookupSlot()) {

- ASSERT(op == Token::ASSIGN || op == Token::INIT_VAR ||

- op == Token::ASSIGN_ADD);

// Assignment to var.

__ push(eax); // Value.

__ push(esi); // Context.

« no previous file with comments | « src/arm64/full-codegen-arm64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »