Node.replaceChild and Node.removeChild do not use custom binding anymore

Node.replaceChild and Node.removeChild do not use custom binding anymore

This CL made those two methods use code generation
by removing Custom keyword from Node.idl
Then enabled interface type checking so appropriate TypeError
will be thrown as per sepc.

SPEC: http://www.w3.org/TR/WebIDL/#es-interface

TEST=fast/dom/Document/replaceChild-null-oldChild.html
    ,fast/events/remove-target-with-shadow-in-drag.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178000

[kangil_, 2014-07-12 04:57:56]

PTAL

[haraken, 2014-07-12 06:08:12]

https://codereview.chromium.org/385073015/diff/20001/Source/core/dom/Containe...
File Source/core/dom/ContainerNode.cpp (right):

https://codereview.chromium.org/385073015/diff/20001/Source/core/dom/Containe...
Source/core/dom/ContainerNode.cpp:334: if (!oldChild.get()) {

.get() is not necessary.

https://codereview.chromium.org/385073015/diff/20001/Source/core/dom/Containe...
Source/core/dom/ContainerNode.cpp:343: if (exceptionState.hadException())

Is it possible that checkAcceptChild returns false without setting
exceptionState.hadException()?

https://codereview.chromium.org/385073015/diff/20001/Source/core/dom/Containe...
Source/core/dom/ContainerNode.cpp:368: if (exceptionState.hadException())

Ditto.

https://codereview.chromium.org/385073015/diff/20001/Source/core/dom/Containe...
Source/core/dom/ContainerNode.cpp:380: if (exceptionState.hadException())

Ditto.

https://codereview.chromium.org/385073015/diff/20001/Source/core/dom/Containe...
Source/core/dom/ContainerNode.cpp:538: if (!oldChild.get() ||
oldChild->parentNode() != this || oldChild->isPseudoElement()) {

.get() is not necessary.

[kangil_, 2014-07-12 06:15:20]

PTAL

https://codereview.chromium.org/385073015/diff/20001/Source/core/dom/Containe...
File Source/core/dom/ContainerNode.cpp (right):

https://codereview.chromium.org/385073015/diff/20001/Source/core/dom/Containe...
Source/core/dom/ContainerNode.cpp:334: if (!oldChild.get()) {
On 2014/07/12 06:08:12, haraken wrote:
> 
> .get() is not necessary.

Done.

https://codereview.chromium.org/385073015/diff/20001/Source/core/dom/Containe...
Source/core/dom/ContainerNode.cpp:343: if (exceptionState.hadException())
On 2014/07/12 06:08:11, haraken wrote:
> 
> Is it possible that checkAcceptChild returns false without setting
> exceptionState.hadException()?

Please refer to https://codereview.chromium.org/375293002/#msg27
Surprisingly it happened.

https://codereview.chromium.org/385073015/diff/20001/Source/core/dom/Containe...
Source/core/dom/ContainerNode.cpp:368: if (exceptionState.hadException())
On 2014/07/12 06:08:11, haraken wrote:
> 
> Ditto.

Done.

https://codereview.chromium.org/385073015/diff/20001/Source/core/dom/Containe...
Source/core/dom/ContainerNode.cpp:380: if (exceptionState.hadException())
On 2014/07/12 06:08:12, haraken wrote:
> 
> Ditto.

Done.

https://codereview.chromium.org/385073015/diff/20001/Source/core/dom/Containe...
Source/core/dom/ContainerNode.cpp:538: if (!oldChild.get() ||
oldChild->parentNode() != this || oldChild->isPseudoElement()) {
On 2014/07/12 06:08:12, haraken wrote:
> 
> .get() is not necessary.

Done.

[haraken, 2014-07-12 15:42:33]

LGTM

[kangil_, 2014-07-12 15:44:14]

The CQ bit was checked by kangil.han@samsung.com

[commit-bot: I haz the power, 2014-07-12 15:44:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kangil.han@samsung.com/385073015/40001

[commit-bot: I haz the power, 2014-07-12 16:56:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/16586)

[commit-bot: I haz the power, 2014-07-12 19:33:00]

Change committed as 178000