Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: Source/bindings/core/v8/custom/V8NodeCustom.cpp

Issue 385073015: Node.replaceChild and Node.removeChild do not use custom binding anymore (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take review comment into consideration Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8NodeCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8NodeCustom.cpp b/Source/bindings/core/v8/custom/V8NodeCustom.cpp
index c7a17c8d1ab68b9c4a3154f668282f80e16a5c67..d6e1f61e22c456857fc9ceb2ee3272888bdda9f0 100644
--- a/Source/bindings/core/v8/custom/V8NodeCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8NodeCustom.cpp
@@ -58,37 +58,6 @@ namespace WebCore {
// These functions are custom to prevent a wrapper lookup of the return value which is always
// part of the arguments.
-void V8Node::replaceChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- v8::Handle<v8::Object> holder = info.Holder();
- Node* impl = V8Node::toNative(holder);
-
- CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
-
- ExceptionState exceptionState(ExceptionState::ExecutionContext, "replaceChild", "Node", info.Holder(), info.GetIsolate());
- Node* newChild = V8Node::toNativeWithTypeCheck(info.GetIsolate(), info[0]);
- Node* oldChild = V8Node::toNativeWithTypeCheck(info.GetIsolate(), info[1]);
- impl->replaceChild(newChild, oldChild, exceptionState);
- if (exceptionState.throwIfNeeded())
- return;
- v8SetReturnValue(info, info[1]);
-}
-
-void V8Node::removeChildMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- v8::Handle<v8::Object> holder = info.Holder();
- Node* impl = V8Node::toNative(holder);
-
- CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope;
-
- ExceptionState exceptionState(ExceptionState::ExecutionContext, "removeChild", "Node", info.Holder(), info.GetIsolate());
- Node* oldChild = V8Node::toNativeWithTypeCheck(info.GetIsolate(), info[0]);
- impl->removeChild(oldChild, exceptionState);
- if (exceptionState.throwIfNeeded())
- return;
- v8SetReturnValue(info, info[0]);
-}
-
v8::Handle<v8::Object> wrap(Node* impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
{
ASSERT(impl);
« no previous file with comments | « LayoutTests/fast/events/remove-target-with-shadow-in-drag-expected.txt ('k') | Source/core/dom/ContainerNode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698