LayoutTests/fast/dom/Document/script-tests/replaceChild-null-oldChild.js - Issue 385073015: Node.replaceChild and Node.removeChild do not use custom binding anymore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/Document/script-tests/replaceChild-null-oldChild.js

Issue 385073015: Node.replaceChild and Node.removeChild do not use custom binding anymore (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take review comment into consideration Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/Document/replaceChild-null-oldChild-expected.txt ('k') | LayoutTests/fast/events/remove-target-with-shadow-in-drag-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/Document/script-tests/replaceChild-null-oldChild.js

diff --git a/LayoutTests/fast/dom/Document/script-tests/replaceChild-null-oldChild.js b/LayoutTests/fast/dom/Document/script-tests/replaceChild-null-oldChild.js

index 3b833f00b4e4c4aab4f7e0a119c4dfc6c08120a9..9813699bd72485f14d5b399d4e9e48dc14bc0d25 100644

--- a/LayoutTests/fast/dom/Document/script-tests/replaceChild-null-oldChild.js

+++ b/LayoutTests/fast/dom/Document/script-tests/replaceChild-null-oldChild.js

@@ -1,3 +1,3 @@

description('Test behavior of Document.replaceChild() when oldChild is null.');

-shouldThrow('document.replaceChild(document.firstChild, null)', '"NotFoundError: Failed to execute \'replaceChild\' on \'Node\': The node to be replaced is null."');

+shouldThrow('document.replaceChild(document.firstChild, null)', '"TypeError: Failed to execute \'replaceChild\' on \'Node\': parameter 2 is not of type \'Node\'."');