This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed,

net/socket/ssl_client_socket.h

Index: net/socket/ssl_client_socket.h
diff --git a/net/socket/ssl_client_socket.h b/net/socket/ssl_client_socket.h
index 74423c1a626194545e5c672d466f485f819f1a62..9b8dae0003b63b74aa1097b06c6c0a93552a5077 100644
--- a/net/socket/ssl_client_socket.h
+++ b/net/socket/ssl_client_socket.h
@@ -83,18 +83,10 @@ class NET_EXPORT SSLClientSocket : public SSLSocket {
   virtual bool WasNpnNegotiated() const OVERRIDE;
   virtual NextProto GetNegotiatedProtocol() const OVERRIDE;
 
-  // Formats a unique key for the SSL session cache. This method
-  // is necessary so that all classes create cache keys in a consistent
-  // manner.
-  // TODO(mshelley) This method will be deleted in an upcoming CL when
-  // it will no longer be necessary to generate a cache key outside of
-  // an SSLClientSocket.
-  static std::string CreateSessionCacheKey(
-      const HostPortPair& host_and_port,
-      const std::string& ssl_session_cache_shard);
-
-  // Returns true if there is a cache entry in the SSL session cache
-  // for the cache key of the SSL socket.
+  virtual std::string GetSessionCacheKey() const = 0;

[wtc, 2014/08/12 14:51:00]

Please document this method.

Can you explain why you used to believe you could delete this method? (See your
TODO comment on line 89 in the original code.)

Note: I suspect this might be a merge error.

[mshelley, 2014/08/12 21:47:01]

My comment below meant that I could delete the static CreateSessionCacheKey
method because I no longer need to have a cache key prior to the creation of a
socket, because now I don't create messengers until after I've created a socket.


Thus, I replaced the static method with GetSessionCacheKey. Someone suggested
doing this on an earlier CL I believe. 

+
+  // Returns true if there is a cache entry in the ssl session cache
+  // for the given cache key.

[wtc, 2014/08/12 14:51:00]

This seems to be a merge error. The original comment is better. Please undo this
change.

[mshelley, 2014/08/12 21:47:00]

Done.

   //
   // The cache key consists of a host and port concatenated with a session
   // cache shard. These two strings are passed to the constructor of most