net/socket/socks_client_socket_pool.cc - Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks_client_socket_pool.cc

Issue 384873002: This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed, (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useloop

Patch Set: Rebase, fixed issue where messenger field wasn't set to NULL after deletion Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/socks_client_socket_pool.cc

diff --git a/net/socket/socks_client_socket_pool.cc b/net/socket/socks_client_socket_pool.cc

index e11b7a48db5b6f8e8ed21823d2afdd718a473c8d..ae57a1f02ab775c9fbaa514f5fbbd77480421761 100644

--- a/net/socket/socks_client_socket_pool.cc

+++ b/net/socket/socks_client_socket_pool.cc

@@ -172,7 +172,7 @@ scoped_ptr<ConnectJob>

SOCKSClientSocketPool::SOCKSConnectJobFactory::NewConnectJob(

const std::string& group_name,

const PoolBase::Request& request,

- ConnectJob::Delegate* delegate) const {

+ ConnectJob::Delegate* delegate) {

return scoped_ptr<ConnectJob>(new SOCKSConnectJob(group_name,

request.priority(),

request.params(),

« net/socket/socket_test_util.cc ('K') | « net/socket/socks_client_socket_pool.h ('k') | net/socket/ssl_client_socket.h » ('j') | net/socket/ssl_client_socket.h » ('J')