This CL changes the lifespan of SSLConnectJobMessengers so that they are created only when needed,

net/socket/ssl_client_socket.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_SSL_CLIENT_SOCKET_H_
 #define NET_SOCKET_SSL_CLIENT_SOCKET_H_
 
 #include <string>
 
 #include "base/gtest_prod_util.h"
@@ skipping 65 matching lines @@
     kNextProtoUnsupported = 0,  // The server doesn't support NPN.
     kNextProtoNegotiated = 1,   // We agreed on a protocol.
     kNextProtoNoOverlap = 2,    // No protocols in common. We requested
                                 // the first protocol in our list.
   };
 
   // StreamSocket:
   virtual bool WasNpnNegotiated() const OVERRIDE;
   virtual NextProto GetNegotiatedProtocol() const OVERRIDE;
 
-  // Formats a unique key for the SSL session cache. This method
-  // is necessary so that all classes create cache keys in a consistent
-  // manner.
-  // TODO(mshelley) This method will be deleted in an upcoming CL when
-  // it will no longer be necessary to generate a cache key outside of
-  // an SSLClientSocket.
-  static std::string CreateSessionCacheKey(
-      const HostPortPair& host_and_port,
-      const std::string& ssl_session_cache_shard);
+  virtual std::string GetSessionCacheKey() const = 0;

[wtc, 2014/08/12 14:51:00]

Please document this method.

Can you explain why you used to believe you could delete this method? (See your
TODO comment on line 89 in the original code.)

Note: I suspect this might be a merge error.

[mshelley, 2014/08/12 21:47:01]

My comment below meant that I could delete the static CreateSessionCacheKey
method because I no longer need to have a cache key prior to the creation of a
socket, because now I don't create messengers until after I've created a socket.


Thus, I replaced the static method with GetSessionCacheKey. Someone suggested
doing this on an earlier CL I believe. 

 
-  // Returns true if there is a cache entry in the SSL session cache
-  // for the cache key of the SSL socket.
+  // Returns true if there is a cache entry in the ssl session cache
+  // for the given cache key.

[wtc, 2014/08/12 14:51:00]

This seems to be a merge error. The original comment is better. Please undo this
change.

[mshelley, 2014/08/12 21:47:00]

Done.

   //
   // The cache key consists of a host and port concatenated with a session
   // cache shard. These two strings are passed to the constructor of most
   // subclasses of SSLClientSocket.
   virtual bool InSessionCache() const = 0;
 
   // Sets |callback| to be run when the handshake has fully completed.
   // For example, in the case of False Start, Connect() will return
   // early, before the peer's TLS Finished message has been verified,
   // in order to allow the caller to call Write() and send application
@@ skipping 116 matching lines @@
   bool channel_id_sent_;
   // True if SCTs were received via a TLS extension.
   bool signed_cert_timestamps_received_;
   // True if a stapled OCSP response was received.
   bool stapled_ocsp_response_received_;
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_SSL_CLIENT_SOCKET_H_