Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/browser/extensions/tab_helper.cc

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/tab_helper.cc
diff --git a/chrome/browser/extensions/tab_helper.cc b/chrome/browser/extensions/tab_helper.cc
index 2759429542ee61d3e3976c3807bfb7661746bebc..bde2e6fca6beebfcdf864dd8a9ced54b8442889d 100644
--- a/chrome/browser/extensions/tab_helper.cc
+++ b/chrome/browser/extensions/tab_helper.cc
@@ -385,8 +385,10 @@ void TabHelper::OnInlineWebstoreInstall(int install_id,
return_route_id, this, webstore_item_id, listeners_mask);
WebstoreStandaloneInstaller::Callback callback =
- base::Bind(&TabHelper::OnInlineInstallComplete, base::Unretained(this),
- install_id, return_route_id);
+ base::Bind(&TabHelper::OnInlineInstallComplete,
+ base::Unretained(this),
+ install_id,
+ return_route_id);
scoped_refptr<WebstoreInlineInstaller> installer(
webstore_inline_installer_factory_->CreateInstaller(
web_contents(),
@@ -516,9 +518,14 @@ WindowController* TabHelper::GetExtensionWindowController() const {
void TabHelper::OnInlineInstallComplete(int install_id,
int return_route_id,
bool success,
- const std::string& error) {
+ const std::string& error,
+ webstore_install::Result result) {
Send(new ExtensionMsg_InlineWebstoreInstallResponse(
- return_route_id, install_id, success, success ? std::string() : error));
+ return_route_id,
+ install_id,
+ success,
+ success ? std::string() : error,
+ result));
}
WebContents* TabHelper::GetAssociatedWebContents() const {

Powered by Google App Engine
This is Rietveld 408576698