chrome/browser/extensions/webstore_inline_installer_browsertest.cc - Issue 384823002: Introduce a stable set of errors for inline install

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/webstore_inline_installer_browsertest.cc

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/webstore_inline_installer_browsertest.cc

diff --git a/chrome/browser/extensions/webstore_inline_installer_browsertest.cc b/chrome/browser/extensions/webstore_inline_installer_browsertest.cc

index 7146bdb81ce56306b516be77971119fa4eb9d2de..2da587cc81ac297bbec56ff6d220c99a84b63a57 100644

--- a/chrome/browser/extensions/webstore_inline_installer_browsertest.cc

+++ b/chrome/browser/extensions/webstore_inline_installer_browsertest.cc

@@ -106,7 +106,9 @@ class WebstoreInlineInstallerForTest : public WebstoreInlineInstaller {

friend class base::RefCountedThreadSafe<WebstoreStandaloneInstaller>;

- static void DummyCallback(bool /*success*/, const std::string& /*error*/) {

+ static void DummyCallback(bool success,

+ const std::string& error,

+ webstore_install::Result result) {

}

ProgrammableInstallPrompt* programmable_prompt_;