chrome/browser/extensions/tab_helper.h - Issue 384823002: Introduce a stable set of errors for inline install

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/tab_helper.h

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/tab_helper.h

diff --git a/chrome/browser/extensions/tab_helper.h b/chrome/browser/extensions/tab_helper.h

index 9725f211d77d2ae60cac07a9f261cc5b383f5a8d..579318451dfe58ac7a7a71f94de3ad60335d4820 100644

--- a/chrome/browser/extensions/tab_helper.h

+++ b/chrome/browser/extensions/tab_helper.h

@@ -15,6 +15,7 @@

#include "base/memory/weak_ptr.h"

#include "base/observer_list.h"

#include "chrome/browser/extensions/active_tab_permission_granter.h"

+#include "chrome/common/extensions/webstore_install_result.h"

#include "chrome/common/web_application_info.h"

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

@@ -224,7 +225,8 @@ class TabHelper : public content::WebContentsObserver,

virtual void OnInlineInstallComplete(int install_id,

int return_route_id,

bool success,

- const std::string& error);

+ const std::string& error,

+ webstore_install::Result result);

// content::NotificationObserver.

virtual void Observe(int type,