chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc - Issue 384823002: Introduce a stable set of errors for inline install

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/private_api_misc.h ('k') | chrome/browser/chromeos/file_manager/app_installer.cc » ('j') | chrome/common/extensions/api/webstore.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

index 41783b3c23217c1d193b85040be3d2e61f577e32..181b4ba4bba533c3681acb840d4a571ae3e89a4f 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

@@ -283,7 +283,8 @@ bool FileBrowserPrivateInstallWebstoreItemFunction::RunAsync() {

void FileBrowserPrivateInstallWebstoreItemFunction::OnInstallComplete(

bool success,

- const std::string& error) {

+ const std::string& error,

+ extensions::webstore_install::Result result) {

drive::EventLogger* logger = file_manager::util::GetLogger(GetProfile());

if (success) {

if (logger) {