Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_misc.h" 5 #include "chrome/browser/chromeos/extensions/file_manager/private_api_misc.h"
6 6
7 #include "apps/app_window.h" 7 #include "apps/app_window.h"
8 #include "apps/app_window_registry.h" 8 #include "apps/app_window_registry.h"
9 #include "ash/frame/frame_util.h" 9 #include "ash/frame/frame_util.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 params->item_id, 276 params->item_id,
277 GetProfile(), 277 GetProfile(),
278 callback)); 278 callback));
279 // installer will be AddRef()'d in BeginInstall(). 279 // installer will be AddRef()'d in BeginInstall().
280 installer->BeginInstall(); 280 installer->BeginInstall();
281 return true; 281 return true;
282 } 282 }
283 283
284 void FileBrowserPrivateInstallWebstoreItemFunction::OnInstallComplete( 284 void FileBrowserPrivateInstallWebstoreItemFunction::OnInstallComplete(
285 bool success, 285 bool success,
286 const std::string& error) { 286 const std::string& error,
287 extensions::webstore_install::Result result) {
287 drive::EventLogger* logger = file_manager::util::GetLogger(GetProfile()); 288 drive::EventLogger* logger = file_manager::util::GetLogger(GetProfile());
288 if (success) { 289 if (success) {
289 if (logger) { 290 if (logger) {
290 logger->Log(logging::LOG_INFO, 291 logger->Log(logging::LOG_INFO,
291 "App install succeeded. (item id: %s)", 292 "App install succeeded. (item id: %s)",
292 webstore_item_id_.c_str()); 293 webstore_item_id_.c_str());
293 } 294 }
294 } else { 295 } else {
295 if (logger) { 296 if (logger) {
296 logger->Log(logging::LOG_ERROR, 297 logger->Log(logging::LOG_ERROR,
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
470 NOTREACHED(); 471 NOTREACHED();
471 SetError( 472 SetError(
472 base::StringPrintf("Unexpected inspection type(%d) is specified.", 473 base::StringPrintf("Unexpected inspection type(%d) is specified.",
473 static_cast<int>(params->type))); 474 static_cast<int>(params->type)));
474 return false; 475 return false;
475 } 476 }
476 return true; 477 return true;
477 } 478 }
478 479
479 } // namespace extensions 480 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698