chrome/browser/chromeos/file_manager/app_installer.cc - Issue 384823002: Introduce a stable set of errors for inline install

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/file_manager/app_installer.cc

Issue 384823002: Introduce a stable set of errors for inline install (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Replace printf with vlog(1) in unrelated code so it passes presubmit Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/file_manager/app_installer.cc

diff --git a/chrome/browser/chromeos/file_manager/app_installer.cc b/chrome/browser/chromeos/file_manager/app_installer.cc

index dc1fd4a8e0d8fc77ed73455052ededfaabd5e65b..18ffcd52bc5f82da3d793813a7a71c8f2a0296a7 100644

--- a/chrome/browser/chromeos/file_manager/app_installer.cc

+++ b/chrome/browser/chromeos/file_manager/app_installer.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/chromeos/file_manager/app_installer.h"

+#include "chrome/common/extensions/webstore_install_result.h"

#include "content/public/browser/web_contents.h"

#include "content/public/browser/web_contents_observer.h"

@@ -96,7 +97,9 @@ bool AppInstaller::CheckRequestorPermitted(

void AppInstaller::OnWebContentsDestroyed(

content::WebContents* web_contents) {

- callback_.Run(false, kWebContentsDestroyedError);

+ callback_.Run(false,

+ kWebContentsDestroyedError,

+ extensions::webstore_install::OTHER_ERROR);

AbortInstall();

}