Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 384773004: IDL clean-up: Rename is_nullable_simple => is_implicit_nullable (Closed)

Created:
6 years, 5 months ago by Jens Widell
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@idl-nullable-method-return-type
Project:
blink
Visibility:
Public.

Description

IDL clean-up: Rename is_nullable_simple => is_implicit_nullable ... and introduce is_explicit_nullable that is mutually exclusive (for nullable types.) It turns out that the only actual use of is_implicit_nullable right now is in the definition of is_explicit_nullable, but having both is fine, for symmetry. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177912

Patch Set 1 #

Total comments: 2

Patch Set 2 : order, order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 1 5 chunks +4 lines, -6 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 2 chunks +16 lines, -3 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Jens Widell
PTAL It turns out the reason the previous design was wrong was that it was ...
6 years, 5 months ago (2014-07-10 15:44:05 UTC) #1
haraken
LGTM https://codereview.chromium.org/384773004/diff/1/Source/bindings/scripts/v8_attributes.py File Source/bindings/scripts/v8_attributes.py (right): https://codereview.chromium.org/384773004/diff/1/Source/bindings/scripts/v8_attributes.py#newcode117 Source/bindings/scripts/v8_attributes.py:117: 'is_explicit_nullable': idl_type.is_explicit_nullable, alphabetical order
6 years, 5 months ago (2014-07-10 15:48:16 UTC) #2
Jens Widell
https://codereview.chromium.org/384773004/diff/1/Source/bindings/scripts/v8_attributes.py File Source/bindings/scripts/v8_attributes.py (right): https://codereview.chromium.org/384773004/diff/1/Source/bindings/scripts/v8_attributes.py#newcode117 Source/bindings/scripts/v8_attributes.py:117: 'is_explicit_nullable': idl_type.is_explicit_nullable, On 2014/07/10 15:48:16, haraken wrote: > alphabetical ...
6 years, 5 months ago (2014-07-10 15:53:18 UTC) #3
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 5 months ago (2014-07-11 06:29:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/384773004/20001
6 years, 5 months ago (2014-07-11 06:29:36 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-11 07:39:46 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-11 08:11:50 UTC) #7
Message was sent while issue was closed.
Change committed as 177912

Powered by Google App Engine
This is Rietveld 408576698