Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: Source/bindings/templates/attributes.cpp

Issue 384773004: IDL clean-up: Rename is_nullable_simple => is_implicit_nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-nullable-method-return-type
Patch Set: order, order Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/attributes.cpp
diff --git a/Source/bindings/templates/attributes.cpp b/Source/bindings/templates/attributes.cpp
index 23187d1ed7d805fb9beebd857c4aa5b249a4c113..36e646ee5185e5cec2c5c44050e6cdca963ee123 100644
--- a/Source/bindings/templates/attributes.cpp
+++ b/Source/bindings/templates/attributes.cpp
@@ -45,7 +45,7 @@ const v8::PropertyCallbackInfo<v8::Value>& info
attribute.is_getter_raises_exception %}
ExceptionState exceptionState(ExceptionState::GetterContext, "{{attribute.name}}", "{{interface_name}}", holder, info.GetIsolate());
{% endif %}
- {% if attribute.is_nullable and not attribute.is_nullable_simple %}
+ {% if attribute.is_explicit_nullable %}
bool isNull = false;
{% endif %}
{% if attribute.is_implemented_in_private_script %}
@@ -73,7 +73,7 @@ const v8::PropertyCallbackInfo<v8::Value>& info
attribute.cpp_value)
| indent}}
{% endif %}
- {% if attribute.is_nullable and not attribute.is_nullable_simple %}
+ {% if attribute.is_explicit_nullable %}
if (isNull) {
v8SetReturnValueNull(info);
return;
« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698