Source/bindings/templates/methods.cpp - Issue 384773004: IDL clean-up: Rename is_nullable_simple => is_implicit_nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/methods.cpp

Issue 384773004: IDL clean-up: Rename is_nullable_simple => is_implicit_nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@idl-nullable-method-return-type

Patch Set: order, order Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/methods.cpp

diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp

index 4ce408a59b5aa344e0e771e271ffad433a7c281d..fde664e1b232b45160ea20ed02d18d34a5f5cadf 100644

--- a/Source/bindings/templates/methods.cpp

+++ b/Source/bindings/templates/methods.cpp

@@ -268,7 +268,7 @@ if (exceptionState.hadException()) {

{%- elif method.union_arguments %}

{%- elif v8_set_return_value %}

-{% if method.is_nullable %}

+{% if method.is_explicit_nullable %}

if (result.isNull())

v8SetReturnValueNull(info);

else

« no previous file with comments | « Source/bindings/templates/attributes.cpp ('k') | no next file » | no next file with comments »