Issue 3835002: base: Remove 'using' declaration of StringAppendV.

Issue 3835002: base: Remove 'using' declaration of StringAppendV. (Closed)

Created:
10 years, 2 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
brettw, akalin

CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, ben+cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, jshin+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, tim (not reviewing)

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

base: Remove 'using' declaration of StringAppendV. In the same time fix the callers appending base:: to it. BUG=None TEST=trybots

Patch Set 1 : #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -9 lines)			Patch
M	base/stringprintf.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/notifier/chrome_system_resources.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/update_manifest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	skia/ext/google_logging.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/examples/example_base.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/pepper_test_plugin/main.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tfarina

From the logs this will need a fix in google-cache-validation http://build.chromium.org/buildbot/try-server/builders/linux/builds/50466/steps/compile/logs/stdio +akalin

10 years, 2 months ago (2010-10-16 22:30:05 UTC) #2

tfarina

On 2010/10/18 05:37:35, brettw wrote: > LGTM (when cache invalidation is fixed) Fred, could you ...

10 years, 2 months ago (2010-10-18 15:27:37 UTC) #4

tfarina

Closing this for now, until cache-invalidation is fixed.

10 years, 2 months ago (2010-10-21 00:11:15 UTC) #5

akalin

10 years, 1 month ago (2010-10-27 01:18:07 UTC) #6

You should be able to just edit
third_party/cacheinvalidation/overrides/google/cacheinvalidation/string_util.h
as normal.  It's not part of the cacheinvalidation svn checkout, since it's an
override file.

On 2010/10/21 00:11:15, tfarina wrote:
> Closing this for now, until cache-invalidation is fixed.

Expand Messages | Collapse Messages