Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: skia/ext/google_logging.cc

Issue 3835002: base: Remove 'using' declaration of StringAppendV. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/common/extensions/update_manifest.cc ('k') | views/examples/example_base.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file provides integration with Google-style "base/logging.h" assertions 5 // This file provides integration with Google-style "base/logging.h" assertions
6 // for Skia SkASSERT. If you don't want this, you can link with another file 6 // for Skia SkASSERT. If you don't want this, you can link with another file
7 // that provides integration with the logging of your choice. 7 // that provides integration with the logging of your choice.
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
11 11
12 void SkDebugf_FileLine(const char* file, int line, bool fatal, 12 void SkDebugf_FileLine(const char* file, int line, bool fatal,
13 const char* format, ...) { 13 const char* format, ...) {
14 va_list ap; 14 va_list ap;
15 va_start(ap, format); 15 va_start(ap, format);
16 16
17 std::string msg; 17 std::string msg;
18 StringAppendV(&msg, format, ap); 18 base::StringAppendV(&msg, format, ap);
19 19
20 logging::LogMessage(file, line, 20 logging::LogMessage(file, line,
21 fatal ? logging::LOG_FATAL : logging::LOG_INFO).stream() 21 fatal ? logging::LOG_FATAL : logging::LOG_INFO).stream()
22 << msg; 22 << msg;
23 } 23 }
OLDNEW
« no previous file with comments | « chrome/common/extensions/update_manifest.cc ('k') | views/examples/example_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698