Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 383373002: Revert 282837 because it broke non-chromeos builds. (Closed)

Created:
6 years, 5 months ago by sadrul
Modified:
6 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 282837 because it broke non-chromeos builds. > chromeos: Move some network related UI in ui/chromeos/ > > Move the code responsible for showing network icons into a common component > so that it can be used from both ash and athena. This also moves the relevant > string and image-resources out of ash into separate ui_chromeos_ targets. > > R=mmoss@chromium.org, oshima@chromium.org, sky@chromium.org, stevenjb@chromium.org > TBR=derat@ for third_party/cros_system_api owners > BUG=387199 > > Review URL: https://codereview.chromium.org/351353004 TBR=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -1465 lines) Patch
M trunk/src/ash/ash.gyp View 2 chunks +5 lines, -3 lines 0 comments Download
M trunk/src/ash/ash_chromeos_strings.grdp View 3 chunks +30 lines, -0 lines 0 comments Download
M trunk/src/ash/resources/ash_resources.grd View 1 chunk +32 lines, -0 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/status_network_failed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_1x.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_3g_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_3g_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_4g_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_4g_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_active_portal_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_active_portal_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_arcs_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_arcs_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_bars_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_bars_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_edge_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_edge_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_evdo_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_evdo_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_gprs_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_gprs_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_hspa_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_hspa_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_hspa_plus_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_hspa_plus_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_lte_advanced_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_lte_advanced_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_lte_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_lte_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_roaming_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_roaming_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_secure_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_network_vpn_badge.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_vpn_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_100_percent/cros/network/statusbar_wired.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/status_network_failed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_3g_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_3g_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_4g_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_4g_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_active_portal_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_active_portal_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_arcs_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_arcs_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_bars_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_bars_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_edge_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_edge_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_evdo_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_evdo_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_gprs_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_gprs_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_hspa_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_hspa_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_hspa_plus_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_hspa_plus_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_lte_advanced_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_lte_advanced_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_lte_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_lte_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_roaming_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_roaming_light.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_secure_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_network_vpn_badge.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_vpn_dark.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/resources/default_200_percent/cros/network/statusbar_wired.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ash/system/chromeos/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
A + trunk/src/ash/system/chromeos/network/network_icon.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/system/chromeos/network/network_icon.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/system/chromeos/network/network_icon_animation.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/system/chromeos/network/network_icon_animation.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/system/chromeos/network/network_icon_animation_observer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ash/system/chromeos/network/network_state_list_detailed_view.h View 3 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/ash/system/chromeos/network/network_state_list_detailed_view.cc View 6 chunks +10 lines, -11 lines 0 comments Download
M trunk/src/ash/system/chromeos/network/network_state_notifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ash/system/chromeos/network/tray_network.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ash/system/chromeos/network/tray_network.cc View 8 chunks +15 lines, -18 lines 0 comments Download
M trunk/src/ash/system/chromeos/network/tray_network_state_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/system/chromeos/network/tray_vpn.cc View 7 chunks +12 lines, -13 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/status/network_menu.cc View 8 chunks +13 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/network_dropdown.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_repack_chrome_100_percent.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/chrome_repack_chrome_200_percent.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/chrome_repack_locales.gypi View 2 chunks +1 line, -7 lines 0 comments Download
M trunk/src/chrome/chrome_resources.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/tools/build/repack_locales.py View 5 chunks +0 lines, -11 lines 0 comments Download
M trunk/src/chrome/tools/check_grd_for_unused_strings.py View 3 chunks +1 line, -2 lines 0 comments Download
M trunk/src/tools/gritsettings/resource_ids View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/tools/resources/optimize-png-files.sh View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/chromeos/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D trunk/src/ui/chromeos/network/network_icon.h View 1 chunk +0 lines, -83 lines 0 comments Download
D trunk/src/ui/chromeos/network/network_icon.cc View 1 chunk +0 lines, -962 lines 0 comments Download
D trunk/src/ui/chromeos/network/network_icon_animation.h View 1 chunk +0 lines, -48 lines 0 comments Download
D trunk/src/ui/chromeos/network/network_icon_animation.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D trunk/src/ui/chromeos/network/network_icon_animation_observer.h View 1 chunk +0 lines, -27 lines 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/status_network_failed.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_1x.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_3g_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_3g_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_4g_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_4g_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_active_portal_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_active_portal_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_arcs_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_arcs_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_bars_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_bars_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_edge_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_edge_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_evdo_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_evdo_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_gprs_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_gprs_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_hspa_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_hspa_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_hspa_plus_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_hspa_plus_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_lte_advanced_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_lte_advanced_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_lte_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_lte_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_roaming_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_roaming_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_secure_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_network_vpn_badge.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_vpn_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_100_percent/network/statusbar_wired.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/status_network_failed.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_3g_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_3g_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_4g_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_4g_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_active_portal_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_active_portal_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_arcs_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_arcs_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_bars_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_bars_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_edge_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_edge_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_evdo_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_evdo_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_gprs_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_gprs_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_hspa_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_hspa_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_hspa_plus_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_hspa_plus_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_lte_advanced_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_lte_advanced_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_lte_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_lte_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_roaming_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_roaming_light.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_secure_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_network_vpn_badge.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_vpn_dark.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/default_200_percent/network/statusbar_wired.png View Binary file 0 comments Download
D trunk/src/ui/chromeos/resources/ui_chromeos_resources.grd View 1 chunk +0 lines, -46 lines 0 comments Download
M trunk/src/ui/chromeos/ui_chromeos.gyp View 2 chunks +0 lines, -42 lines 0 comments Download
D trunk/src/ui/chromeos/ui_chromeos_strings.grd View 1 chunk +0 lines, -135 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
6 years, 5 months ago (2014-07-12 19:02:39 UTC) #1
sadrul
6 years, 5 months ago (2014-07-12 19:03:56 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r282839 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698