Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: trunk/src/chrome/tools/check_grd_for_unused_strings.py

Issue 383373002: Revert 282837 because it broke non-chromeos builds. (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/tools/build/repack_locales.py ('k') | trunk/src/tools/gritsettings/resource_ids » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/tools/check_grd_for_unused_strings.py
===================================================================
--- trunk/src/chrome/tools/check_grd_for_unused_strings.py (revision 282838)
+++ trunk/src/chrome/tools/check_grd_for_unused_strings.py (working copy)
@@ -133,7 +133,6 @@
device_base_dir = os.path.join(src_dir, 'device')
ui_base_dir = os.path.join(src_dir, 'ui', 'base',)
ui_base_strings_dir = os.path.join(ui_base_dir, 'strings')
- ui_chromeos_dir = os.path.join(ui_base_dir, 'chromeos', 'strings')
grd_files = [
os.path.join(ash_base_dir, 'ash_strings.grd'),
os.path.join(ash_base_dir, 'resources', 'ash_resources.grd'),
@@ -157,7 +156,6 @@
os.path.join(src_dir, 'ui', 'webui', 'resources', 'webui_resources.grd'),
os.path.join(ui_base_strings_dir, 'app_locale_settings.grd'),
os.path.join(ui_base_strings_dir, 'ui_strings.grd'),
- os.path.join(ui_chromeos_dir, 'ui_chromeos_strings.grd'),
]
# If no source directories were given, default them:
@@ -171,6 +169,7 @@
os.path.join(src_dir, 'device'),
os.path.join(src_dir, 'extensions'),
os.path.join(src_dir, 'ui'),
+ os.path.join(src_dir, 'views'),
# nsNSSCertHelper.cpp has a bunch of ids
os.path.join(src_dir, 'third_party', 'mozilla_security_manager'),
os.path.join(chrome_dir, 'installer'),
« no previous file with comments | « trunk/src/chrome/tools/build/repack_locales.py ('k') | trunk/src/tools/gritsettings/resource_ids » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698