Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 351353004: chromeos: Move some network related UI in ui/chromeos/ (Closed)

Created:
6 years, 5 months ago by sadrul
Modified:
6 years, 5 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, dcheng, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, jennyz
Project:
chromium
Visibility:
Public.

Description

chromeos: Move some network related UI in ui/chromeos/ Move the code responsible for showing network icons into a common component so that it can be used from both ash and athena. This also moves the relevant string and image-resources out of ash into separate ui_chromeos_ targets. R=mmoss@chromium.org, oshima@chromium.org, sky@chromium.org, stevenjb@chromium.org TBR=derat@ for third_party/cros_system_api owners BUG=387199 Previously landed in r282837, and reverted in r282839 because it broke non-chromeos builds. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282858

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : tot-merge #

Patch Set 4 : reverted-cl #

Patch Set 5 : fix-build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -1363 lines) Patch
M ash/ash.gyp View 1 2 3 4 2 chunks +2 lines, -5 lines 0 comments Download
M ash/ash_chromeos_strings.grdp View 1 2 3 chunks +0 lines, -30 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 chunk +0 lines, -32 lines 0 comments Download
D ash/resources/default_100_percent/cros/network/status_network_failed.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_1x.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_3g_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_3g_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_4g_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_4g_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_active_portal_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_active_portal_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_arcs_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_arcs_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_bars_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_bars_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_edge_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_edge_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_evdo_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_evdo_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_gprs_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_gprs_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_hspa_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_hspa_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_hspa_plus_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_hspa_plus_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_lte_advanced_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_lte_advanced_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_lte_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_lte_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_roaming_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_roaming_light.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_secure_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_network_vpn_badge.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_vpn_dark.png View Binary file 0 comments Download
D ash/resources/default_100_percent/cros/network/statusbar_wired.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/status_network_failed.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_3g_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_3g_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_4g_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_4g_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_active_portal_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_active_portal_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_arcs_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_arcs_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_bars_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_bars_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_edge_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_edge_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_evdo_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_evdo_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_gprs_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_gprs_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_hspa_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_hspa_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_hspa_plus_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_hspa_plus_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_lte_advanced_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_lte_advanced_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_lte_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_lte_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_roaming_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_roaming_light.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_secure_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_network_vpn_badge.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_vpn_dark.png View Binary file 0 comments Download
D ash/resources/default_200_percent/cros/network/statusbar_wired.png View Binary file 0 comments Download
M ash/system/chromeos/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
D ash/system/chromeos/network/network_icon.h View 1 chunk +0 lines, -83 lines 0 comments Download
D ash/system/chromeos/network/network_icon.cc View 1 1 chunk +0 lines, -962 lines 0 comments Download
D ash/system/chromeos/network/network_icon_animation.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ash/system/chromeos/network/network_icon_animation.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D ash/system/chromeos/network/network_icon_animation_observer.h View 1 chunk +0 lines, -27 lines 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M ash/system/chromeos/network/network_state_notifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/chromeos/network/tray_network.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 8 chunks +18 lines, -15 lines 0 comments Download
M ash/system/chromeos/network/tray_network_state_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/tray_vpn.cc View 7 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 8 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_repack_chrome_100_percent.gypi View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/chrome_repack_chrome_200_percent.gypi View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/chrome_repack_locales.gypi View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
M chrome/chrome_resources.gyp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/tools/build/repack_locales.py View 1 2 3 4 5 chunks +11 lines, -0 lines 0 comments Download
M chrome/tools/check_grd_for_unused_strings.py View 1 3 chunks +2 lines, -1 line 0 comments Download
M tools/gritsettings/resource_ids View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M tools/resources/optimize-png-files.sh View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
A + ui/chromeos/network/network_icon.h View 2 chunks +18 lines, -18 lines 0 comments Download
A + ui/chromeos/network/network_icon.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + ui/chromeos/network/network_icon_animation.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + ui/chromeos/network/network_icon_animation.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/chromeos/network/network_icon_animation_observer.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/status_network_failed.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_1x.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_3g_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_3g_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_4g_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_4g_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_active_portal_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_active_portal_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_arcs_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_arcs_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_bars_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_bars_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_edge_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_edge_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_evdo_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_evdo_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_gprs_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_gprs_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_hspa_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_hspa_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_hspa_plus_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_hspa_plus_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_lte_advanced_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_lte_advanced_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_lte_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_lte_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_roaming_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_roaming_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_secure_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_network_vpn_badge.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_vpn_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_100_percent/network/statusbar_wired.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/status_network_failed.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_3g_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_3g_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_4g_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_4g_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_active_portal_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_active_portal_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_arcs_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_arcs_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_bars_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_bars_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_edge_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_edge_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_evdo_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_evdo_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_gprs_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_gprs_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_hspa_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_hspa_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_hspa_plus_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_hspa_plus_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_lte_advanced_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_lte_advanced_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_lte_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_lte_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_roaming_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_roaming_light.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_secure_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_network_vpn_badge.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_vpn_dark.png View Binary file 0 comments Download
A + ui/chromeos/resources/default_200_percent/network/statusbar_wired.png View Binary file 0 comments Download
A ui/chromeos/resources/ui_chromeos_resources.grd View 1 chunk +46 lines, -0 lines 0 comments Download
M ui/chromeos/ui_chromeos.gyp View 2 chunks +42 lines, -0 lines 0 comments Download
A ui/chromeos/ui_chromeos_strings.grd View 1 chunk +135 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sadrul
6 years, 5 months ago (2014-07-02 17:41:36 UTC) #1
stevenjb
lgtm cc:jennyz@ FYI
6 years, 5 months ago (2014-07-02 17:56:20 UTC) #2
oshima
lgtm
6 years, 5 months ago (2014-07-08 18:35:28 UTC) #3
sadrul
mmoss@chromium.org: Please review changes in chrome/tools/
6 years, 5 months ago (2014-07-10 13:18:40 UTC) #4
Michael Moss
lgtm
6 years, 5 months ago (2014-07-10 15:22:58 UTC) #5
sadrul
+sky@ for chrome/chrome_resources.gyp, chrome/tools/check_grd_for_unused_strings.py, and chrome/browser/ui/webui/chromeos/login/network_dropdown.h|cc changes
6 years, 5 months ago (2014-07-10 16:40:06 UTC) #6
sky
LGTM
6 years, 5 months ago (2014-07-10 19:14:37 UTC) #7
sadrul
+derat@ for third_party/cros_system_api owners (for DEPS addition in ui/chromeos/DEPS)
6 years, 5 months ago (2014-07-12 18:23:13 UTC) #8
sadrul
Committed patchset #3 manually as r282837 (presubmit successful).
6 years, 5 months ago (2014-07-12 18:30:40 UTC) #9
sadrul
Committed patchset #5 manually as r282858 (presubmit successful).
6 years, 5 months ago (2014-07-13 04:03:52 UTC) #10
Daniel Erat
6 years, 5 months ago (2014-07-14 14:14:16 UTC) #11
Message was sent while issue was closed.
lgtm for ui/chromeos/DEPS

Powered by Google App Engine
This is Rietveld 408576698