Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 382543005: Revert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels (Closed)

Created:
6 years, 5 months ago by reed2
Modified:
6 years, 5 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels (https://codereview.chromium.org/388803007/) Reason for revert: still failing (randomly?) bench sometimes. need stack dump to diagnose. Original issue's description: > Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels > usning it. > > Revert "Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/)" > > This reverts commit d08cb905a7cc80d8fb868bbd14fffe1cd68adcce. > > TBR=scroggo@google.com > > Committed: https://skia.googlesource.com/skia/+/debba5c3d091159149f8a88ab5dcd44dd72e0dc7 TBR=reed@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/651eaeadeb0b1407f5fe192aeda90db1680fa2b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -354 lines) Patch
M include/core/SkBitmap.h View 1 chunk +0 lines, -22 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +13 lines, -14 lines 0 comments Download
M src/core/SkBitmap.cpp View 3 chunks +61 lines, -76 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 3 chunks +74 lines, -2 lines 0 comments Download
M src/core/SkConfig8888.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/core/SkConfig8888.cpp View 2 chunks +0 lines, -142 lines 0 comments Download
M tests/BitmapCopyTest.cpp View 2 chunks +1 line, -94 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed2
Created Revert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels
6 years, 5 months ago (2014-07-12 20:15:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@chromium.org/382543005/1
6 years, 5 months ago (2014-07-12 20:16:04 UTC) #2
commit-bot: I haz the power
Change committed as 651eaeadeb0b1407f5fe192aeda90db1680fa2b8
6 years, 5 months ago (2014-07-12 20:16:15 UTC) #3
reed2
6 years, 5 months ago (2014-07-13 10:59:35 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/392453002/ by reed@chromium.org.

The reason for reverting is: found and fixed the asserts -- we were drawing with
unpremul bitmaps, but our blits assumed they were premul. Fix was to detect this
and just draw nothing..

Powered by Google App Engine
This is Rietveld 408576698