Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: include/core/SkBitmap.h

Issue 382543005: Revert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/core/SkCanvas.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkBitmap.h
diff --git a/include/core/SkBitmap.h b/include/core/SkBitmap.h
index 541db79bb3741a9e3dcdc3ba22dbe2089d6e8096..51e9a9243a13b156ab8591d888b79bbbd11588e6 100644
--- a/include/core/SkBitmap.h
+++ b/include/core/SkBitmap.h
@@ -591,28 +591,6 @@
}
/**
- * Copy the bitmap's pixels into the specified buffer (pixels + rowBytes),
- * converting them into the requested format (SkImageInfo). The src pixels are read
- * starting at the specified (srcX,srcY) offset, relative to the top-left corner.
- *
- * The specified ImageInfo and (srcX,srcY) offset specifies a source rectangle
- *
- * srcR.setXYWH(srcX, srcY, dstInfo.width(), dstInfo.height());
- *
- * srcR is intersected with the bounds of the bitmap. If this intersection is not empty,
- * then we have two sets of pixels (of equal size). Replace the dst pixels with the
- * corresponding src pixels, performing any colortype/alphatype transformations needed
- * (in the case where the src and dst have different colortypes or alphatypes).
- *
- * This call can fail, returning false, for several reasons:
- * - If srcR does not intersect the bitmap bounds.
- * - If the requested colortype/alphatype cannot be converted from the src's types.
- * - If the src pixels are not available.
- */
- bool readPixels(const SkImageInfo& dstInfo, void* dstPixels, size_t dstRowBytes,
- int srcX, int srcY) const;
-
- /**
* Returns true if this bitmap's pixels can be converted into the requested
* colorType, such that copyTo() could succeed.
*/
« no previous file with comments | « no previous file | include/core/SkCanvas.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698