Cleanup return values in autofill

components/autofill/content/renderer/form_autofill_util.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CONTENT_RENDERER_FORM_AUTOFILL_UTIL_H_
 #define COMPONENTS_AUTOFILL_CONTENT_RENDERER_FORM_AUTOFILL_UTIL_H_
 
 #include <vector>
 
 #include "base/strings/string16.h"
@@ skipping 59 matching lines @@
 // Returns true if |element| is one of the input element types that can be
 // autofilled. {Text, Radiobutton, Checkbox}.
 bool IsAutofillableInputElement(const blink::WebInputElement* element);
 
 // Recursively checks whether |node| or any of its children have a non-empty
 // bounding box.
 bool IsWebNodeVisible(const blink::WebNode& node);
 
 // Returns the form's |name| attribute if non-empty; otherwise the form's |id|
 // attribute.
-const base::string16 GetFormIdentifier(const blink::WebFormElement& form);
+const base::string16& GetFormIdentifier(const blink::WebFormElement& form);

[vabr (Chromium), 2014/07/11 13:37:43]

Could this method be const?

[Ilya Sherman, 2014/07/11 19:11:10]

This is a free function, not a method.

[vabr (Chromium), 2014/07/11 19:24:47]

Ah thanks, my bad for missing that.
I take my earlier comment back, since it does not make any sense.

[lucinka.brozkova, 2014/07/11 21:05:57]

Acknowledged.

 
 // Returns true if the element specified by |click_element| was successfully
 // clicked.
 bool ClickElement(const blink::WebDocument& document,
                   const WebElementDescriptor& element_descriptor);
 
 // Fills |autofillable_elements| with all the auto-fillable form control
 // elements in |form_element|.
 void ExtractAutofillableElements(
     const blink::WebFormElement& form_element,
@@ skipping 78 matching lines @@
 // are of the type <script>, <meta>, or <title>.
 bool IsWebElementEmpty(const blink::WebElement& element);
 
 // Return a gfx::RectF that is the bounding box for |element| scaled by |scale|.
 gfx::RectF GetScaledBoundingBox(float scale,
                                 blink::WebFormControlElement* element);
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CONTENT_RENDERER_FORM_AUTOFILL_UTIL_H_